chore: fixed unreachable and incorrectly used code in _examples/bulk #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

CaelRowley wants to merge 1 commit into elastic:main from CaelRowley:chore/examples-bulk-cleanup

CaelRowley commented Jul 6, 2024

Updated / removed deprecated code
Fixed incorrect use of signal.Notify(done, os.Interrupt)
Defer closing of resources that were previously unreachable
Added missing packages to _examples/bulk/kafka/go.mod
Use more idiomatic approach to receive from ticker.C channel


          chore: fixed unreachable and incorrectly used code in _examples/bulk

affd69d

cla-checker-service bot commented Jul 6, 2024 •

edited

Loading

💚 CLA has been signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet