Feat: Add constructor for baseclient #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct
Anaethelion
added a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Apr 16, 2025
* add constructor for BaseClient * expose instrument for esapi to allow injection via struct * use exposed instrument for esapi to allow injection via struct Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a constructor for the
BaseClientwithout an API attached.Easing up usage by passing the client into the endpoints, allowing for a slimmer compiled binary.