Draft
Conversation
- Update go.mod to Go 1.25.5 - Update samples/bundle-remapper/go.mod to Go 1.25.5 - Update build/mage/docker/const.go golang image to 1.25.5 - Update build/mage/golang/init.go version constraint to ~1.25 - Update dependencies including: - github.com/hashicorp/consul/api v1.33.0 - github.com/awnumar/memguard v0.23.0 - golang.org/x/term v0.36.0 - golang.org/x/sys v0.37.0 - golang.org/x/crypto v0.43.0 - golang.org/x/oauth2 v0.32.0 - golang.org/x/sync v0.17.0 - google.golang.org/grpc v1.76.0 - github.com/open-policy-agent/opa v1.9.0 - go.etcd.io/etcd/client/v3 v3.6.5 Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
- pkg/sdk/cmdutil/bug.go: Replace deprecated runtime.GOROOT() with `go env GOROOT` command (deprecated since Go 1.24) - pkg/container/identity/key/json.go: Fix ECDSA P-384 signing by computing public key (X,Y) from private scalar. Go 1.24+ requires the full key to be initialized before signing. - pkg/container/identity/key/generator.go: Pad P-384 key components to fixed 48-byte size. big.Int.Bytes() strips leading zeros which caused "invalid private key size" errors. Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Regenerated with: - protoc-gen-go v1.36.5 - protoc v33.3 Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Regenerated with mockgen for Go 1.25.5 compatibility. Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Add ISC (Internet Systems Consortium) license to approved licenses. Required by github.com/decred/dcrd/dcrec/secp256k1/v4 (transitive dependency from OPA v1.9.0 update). Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
- Update golangci-lint from v1.64.8 to v2.8.0 - Migrate .golangci.yml to v2 configuration format - Update tools/tools.go import paths for v2 - Remove deprecated linters (gofmt, goimports, gosimple, stylecheck) - Update depguard rules for v2 prefix matching Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
- Fix errcheck issues by explicitly ignoring fmt.Fprint* return values - Fix gocritic issue (bytes.Repeat -> make) - Add nolint:gosec directives for intentional file/subprocess operations - Configure revive to disable strict exported comment rules - Configure staticcheck to disable style suggestions (QF*, ST*) - Remove unused nolint:revive directives - Update directory permissions from 0755/0744 to 0750 (G301) Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The PR includes the following updates and changes to update the project to Go 1.25.5.
Go 1.25.5 Update
golangci-lint v2 Migration
Other Changes
Test Plan
cigithub actions tests