This repository was archived by the owner on May 16, 2023. It is now read-only.
Workaround helm template bug when testing for APIVersions#1684
Open
mfrechePgest wants to merge 1 commit intoelastic:7.17from
Open
Workaround helm template bug when testing for APIVersions#1684mfrechePgest wants to merge 1 commit intoelastic:7.17from
mfrechePgest wants to merge 1 commit intoelastic:7.17from
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
4 tasks
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1420 kinda broke chart deployment with ArgoCD on older K8S versions ( < 1.21 )
Issue is related to argoproj/argo-cd#7291
I hope they'll find a fix there but a workaround suggested in the linked issue was to set up more precise
APIVersions.Hasin helm charts.That's the point of this PR
It mirror this PR 7a54fb1 ; adding the Kind to
APIVersions.HasfunctionThx