This repository was archived by the owner on May 16, 2023. It is now read-only.
[kibana] feat: Add support to kibana 6.8 chart for deployment annotations#1754
Open
JDKnobloch wants to merge 1 commit intoelastic:6.8from
Open
[kibana] feat: Add support to kibana 6.8 chart for deployment annotations#1754JDKnobloch wants to merge 1 commit intoelastic:6.8from
JDKnobloch wants to merge 1 commit intoelastic:6.8from
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml^ Unsure if integration test updates are needed with this feature.
This PR creates the ability to add deployment annotations for those using 6.8 versions of elastic. Code used from when changes were introduced to newer versions of the chart in #1417.