-
Notifications
You must be signed in to change notification settings - Fork 73
Fix up enrollment token docs #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you 🚀
If I was to be super nitpicky, I could suggest adding a link to https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-invalidate-api-key.html, for example:
...setting has expired (see Invalidate API key API for details).
I agree with you regarding only mentioning that the token name must be unique. The reason behind it is not 100% clear and there is a possibility it will not always be the case. I've opened elastic/kibana#192469 to capture the open discussion that resulted from the previous doc improvement.
Good idea @jillguyonnet! I've added that link: |
P.S., the new commit automatically removed your approval. Sorry. :-) |
Reapproved 🙂 Thanks for the change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix up enrollment token docs * fixup * fixup * Add link to 'Invalidate API key API' (cherry picked from commit dc3b285)
* Fix up enrollment token docs * fixup * fixup * Add link to 'Invalidate API key API' (cherry picked from commit dc3b285) Co-authored-by: David Kilfoyle <[email protected]>
This adds some detail to clear up usage of Fleet enrollment tokens.
Thanks for the suggestions @jillguyonnet. Let me know if I've missed anything.
Closes: #1270
I think it should be enough for users to know just that the names need to be unique. I added: