Correct incorrect connection_idle_timeout setting #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the wrong `connection_idle_timeout` with the correct `idle_connection_timeout` setting.
toby-sutor
added
documentation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
kilfoyle
approved these changes
Sep 11, 2024
|
P.S. I will merge this and forward fit it into the |
kilfoyle
pushed a commit
to kilfoyle/ingest-docs
that referenced
this pull request
Sep 11, 2024
Correct the wrong `connection_idle_timeout` with the correct `idle_connection_timeout` setting. (cherry picked from commit f1bd746)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kilfoyle
added a commit
that referenced
this pull request
Sep 11, 2024
Correct the wrong `connection_idle_timeout` with the correct `idle_connection_timeout` setting. (cherry picked from commit f1bd746) Co-authored-by: Toby Sutor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the wrong
connection_idle_timeoutwith the correctidle_connection_timeoutsetting.See https://github.com/search?q=repo%3Aelastic%2Fbeats%20idle_connection_timeout&type=code for reference
I think this is also wrong in the automated test: https://github.com/elastic/beats/blob/c75a7a4b3dab942e78fe4c8c48225811ad216b4b/x-pack/filebeat/input/netflow/integration_test.go#L102