Skip to content

Conversation

moxarth-rathod
Copy link
Contributor

Proposed commit message

github: migrate dashboard navigations to using links panel widgets

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Aug 29, 2025
@moxarth-rathod moxarth-rathod added enhancement New feature or request Integration:github GitHub labels Aug 29, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner August 29, 2025 08:59
@moxarth-rathod moxarth-rathod added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Aug 29, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Aug 29, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming the lower panel (currently "Table of Contents") to "Overview" and removing that heading in the text since that panel is now no longer a ToC. Also for the other dashboards.

@@ -189,7 +189,7 @@
"id": "",
"params": {
"fontSize": 12,
"markdown": "**Navigation**\n\n**Github** \n\n- **Audit**\n - [Audit Log Activity](#/dashboard/github-dcee84c0-2059-11ec-8b10-11a4c5e322a0)\n - [User Change Audit](#/dashboard/github-8bfd8310-205c-11ec-8b10-11a4c5e322a0)\n- **Github Advanced Security**\n - [Advanced Security Overview](#/dashboard/github-6a6d7c40-17ab-11ed-809a-7b4be950fe9c)\n - **Code Scanning**\n - [Secret Scanning](#/dashboard/github-591d69e0-17b6-11ed-809a-7b4be950fe9c)\n - [Dependabot](#/dashboard/github-6197be80-220c-11ed-88c4-e3caca48250a)\n- [Issues](#/dashboard/github-f0104680-ae18-11ed-83fa-df5d96a45724)\n- [Security Advisories](#/dashboard/github-e6726e8d-0a94-4917-978a-b5a762b39ee5) \n\n**Overview**\nThis dashboard provides an overview of the alerts ingested from Github Code Scanning.\n\nThe dashboard provides details on code scanning alerts that are open and resolved. It deep-dives into the top 10 repositories where code scanning alerts are found. It also calculates the mean-time to resolve (or dismiss) an open code scanning alert. The dashboard presents a view of alerts by severity and code scanning rules defining the alerts. Finally, it gives a layout of top users resolving the code scanning alerts.\n\n[**Integrations Page**](/app/integrations/detail/github/overview)",
"markdown": "**Overview**\n\nThis dashboard provides an overview of the alerts ingested from Github Code Scanning.\n\nThe dashboard provides details on code scanning alerts that are open and resolved. It deep-dives into the top 10 repositories where code scanning alerts are found. It also calculates the mean-time to resolve (or dismiss) an open code scanning alert. The dashboard presents a view of alerts by severity and code scanning rules defining the alerts. Finally, it gives a layout of top users resolving the code scanning alerts.\n\n[**Integrations Page**](/app/integrations/detail/github/overview)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"markdown": "**Overview**\n\nThis dashboard provides an overview of the alerts ingested from Github Code Scanning.\n\nThe dashboard provides details on code scanning alerts that are open and resolved. It deep-dives into the top 10 repositories where code scanning alerts are found. It also calculates the mean-time to resolve (or dismiss) an open code scanning alert. The dashboard presents a view of alerts by severity and code scanning rules defining the alerts. Finally, it gives a layout of top users resolving the code scanning alerts.\n\n[**Integrations Page**](/app/integrations/detail/github/overview)",
"markdown": "This dashboard provides an overview of the alerts ingested from Github Code Scanning.\n\nThe dashboard provides details on code scanning alerts that are open and resolved. It deep-dives into the top 10 repositories where code scanning alerts are found. It also calculates the mean-time to resolve (or dismiss) an open code scanning alert. The dashboard presents a view of alerts by severity and code scanning rules defining the alerts. Finally, it gives a layout of top users resolving the code scanning alerts.\n\n[**Integrations Page**](/app/integrations/detail/github/overview)",

"i": "bccec7c9-4db6-4cbf-96e7-eabf5a791af0",
"w": 10,
"x": 0,
"y": 0
"y": 13
},
"panelIndex": "bccec7c9-4db6-4cbf-96e7-eabf5a791af0",
"title": "Table of Contents",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Table of Contents",
"title": "Overview",

@moxarth-rathod moxarth-rathod requested a review from efd6 September 1, 2025 11:40
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the link to the integration page. It sort of looks out of place where it is and bolded now. It could be put in the navigation panel, but it would need to be differentiated from the dashboard links with text. I don't have a good answer here, but maybe instead of being a single bolded link, it could be a sentence along the lines of The documentation for the integration is [here](/app/integrations/detail/github/overview). (I'm not convinced by this, so @alaudazzi, do you have a suggestion?)

@alaudazzi
Copy link
Contributor

@efd6

For the sentence

The documentation for the integration is here

consider the following alternative:

Refer to the [integration documentation](/app/integrations/detail/github/overview).

@efd6
Copy link
Contributor

efd6 commented Sep 2, 2025

I'm not sure; maybe we need to understand why that link is actually present. Why are we telling them to refer to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Github] Migrate dashboard navigations to using links panel widgets
5 participants