Skip to content

Remove Security Category Tag from Non-Security Packages #15611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Remove Security Category Tag from Non-Security Packages #15611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5b28f03
Remove security category tag from non-security packages
JDKurma Oct 9, 2025
e5dd75b
Add back 'security' category
JDKurma Oct 10, 2025
b332ed4
Add back 'security' category
JDKurma Oct 10, 2025
e3168d0
Add security category back to manifest.yml
JDKurma Oct 14, 2025
c2e56b3
Add security category back to manifest.yml
JDKurma Oct 14, 2025
c92f88d
revert comment change
JDKurma Oct 14, 2025
ec75bb4
revert comment change
JDKurma Oct 14, 2025
b918827
Merge branch 'main' into remove-miscategorized-security-tags
trisch-me Oct 16, 2025
9d42d2b
Merge branch 'main' into remove-miscategorized-security-tags
trisch-me Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/cisco_meraki_metrics/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ type: integration
categories:
- network
- observability
- security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this was removed? It was added a year ago so I’m concerned if this is a correct approach.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine to assume that the metrics one is purely o11y usecase?

conditions:
kibana:
version: "^8.15.2 || ^9.0.0"
Expand Down
2 changes: 0 additions & 2 deletions packages/miniflux/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ type: integration
categories:
# Observability is a parent category for web
- observability
# Added security category as Miniflux integration is assigned to security team
- security
Comment on lines -12 to -13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clement-fouque Do you recall why this was added as a security integration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had a discussion but I don't remember why we added it. We can remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is owned by security team, has it no security use case?

- web
conditions:
kibana:
Expand Down
4 changes: 0 additions & 4 deletions packages/mongodb/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ type: integration
categories:
- datastore
- observability
# Added database_security category as it collects database logs and metrics including collection statistics, database statistics, and replication status
- database_security
# Added global security category as this integration collects security-relevant data
- security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

icons:
- src: /img/logo_mongodb.svg
title: logo mongodb
Expand Down
4 changes: 0 additions & 4 deletions packages/mysql/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ type: integration
categories:
- datastore
- observability
# Added database_security category as it collects error logs, slow query logs, and replication status metrics that are relevant for database security monitoring
- database_security
# Added global security category as this integration collects security-relevant data
- security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

conditions:
kibana:
version: "^8.15.0 || ^9.0.0"
Expand Down