-
Notifications
You must be signed in to change notification settings - Fork 499
[cisco_ftd] Add support for Security Group Tag and Endpoint Group fields #15652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yahyaghani
wants to merge
3
commits into
elastic:main
Choose a base branch
from
yahyaghani:feat/cisco_ftd-sgt-failing-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,4 @@ fields: | |
external_zones: | ||
- output-zone | ||
internal_zones: | ||
- input-zone | ||
- input-zone |
3 changes: 3 additions & 0 deletions
3
packages/cisco_ftd/data_stream/log/_dev/test/pipeline/test-sgt.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
2025-09-01T12:00:00Z firepower : %FTD-6-430003: EventPriority: Low, DeviceUUID: d697c8ca-9fe4-43e6-aeb5-33e277e5ffea, InstanceID: 11, FirstPacketSecond: 2025-09-01T12:35:00Z, ConnectionID: 39416, AccessControlRuleAction: Trust, SrcIP: 10.0.100.30, DstIP: 10.0.1.20, SrcPort: 56799, DstPort: 53, Protocol: udp, IngressInterface: inside, EgressInterface: outside, SourceSecurityGroup: SGT_TEST_GROUP, SourceSecurityGroupTag: 2003, SourceSecurityGroupType: Session Directory, DestinationIP_DynamicAttribute: APIC_EPG_TEST_GROUP, IngressVRF: Global, EgressVRF: Global, Endpoint Profile: Workstation:Microsoft-Workstation:Windows11-Workstation, ACPolicy: ACP-Access, AccessControlRuleName: Test-Rule-1, Prefilter Policy: Default Prefilter Policy, User: testuser, Client: DNS, ApplicationProtocol: DNS, ConnectionDuration: 0, InitiatorPackets: 1, ResponderPackets: 1, InitiatorBytes: 31, ResponderBytes: 238, NAPPolicy: Balanced Security and Connectivity | ||
2025-09-01T14:00:00Z firepower : %FTD-6-430002: EventPriority: Low, DeviceUUID: d697c8ca-9fe4-43e6-aeb5-33e277e5ffea, InstanceID: 4, FirstPacketSecond: 2025-09-01T14:00:03Z, ConnectionID: 36584, AccessControlRuleAction: Block, SrcIP: 10.0.100.30, DstIP: 10.0.1.20, SrcPort: 56799, DstPort: 22, Protocol: tcp, IngressInterface: inside, EgressInterface: outside, SourceSecurityGroup: 2005, SourceSecurityGroupTag: 2005, DestinationSecurityGroup: 9, DestinationSecurityGroupTag: 9, SourceSecurityGroupType: Session Directory, DestinationSecurityGroupType: SXP, IngressVRF: Global, EgressVRF: Global, Endpoint Profile: Invalid ID, ACPolicy: ACP-Management, AccessControlRuleName: Default Deny, Prefilter Policy: Management Prefilter Policy, InitiatorPackets: 1, ResponderPackets: 0, InitiatorBytes: 70, ResponderBytes: 0, NAPPolicy: Balanced Security and Connectivity | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can remove this empty log line |
283 changes: 283 additions & 0 deletions
283
packages/cisco_ftd/data_stream/log/_dev/test/pipeline/test-sgt.log-expected.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,283 @@ | ||
{ | ||
"expected": [ | ||
{ | ||
"@timestamp": "2025-09-01T12:35:00.000Z", | ||
"cisco": { | ||
"ftd": { | ||
"destination_interface": "outside", | ||
"rule_name": [ | ||
"ACP-Access", | ||
"Test-Rule-1" | ||
], | ||
"security": { | ||
"endpoint_profile": "Workstation:Microsoft-Workstation:Windows11-Workstation" | ||
}, | ||
"security_event": { | ||
"ac_policy": "ACP-Access", | ||
"access_control_rule_action": "Trust", | ||
"access_control_rule_name": "Test-Rule-1", | ||
"application_protocol": "DNS", | ||
"client": "DNS", | ||
"connection_duration": 0, | ||
"destination_ip_dynamic_attribute": "APIC_EPG_TEST_GROUP", | ||
"dst_ip": "10.0.1.20", | ||
"dst_port": 53, | ||
"egress_interface": "outside", | ||
"first_packet_second": "2025-09-01T12:35:00Z", | ||
"ingress_interface": "inside", | ||
"initiator_bytes": 31, | ||
"initiator_packets": 1, | ||
"nap_policy": "Balanced Security and Connectivity", | ||
"prefilter_policy": "Default Prefilter Policy", | ||
"protocol": "udp", | ||
"responder_bytes": 238, | ||
"responder_packets": 1, | ||
"source_security_group": "SGT_TEST_GROUP", | ||
"source_security_group_tag": "2003", | ||
"source_security_group_type": "Session Directory", | ||
"src_ip": "10.0.100.30", | ||
"src_port": 56799, | ||
"user": "testuser" | ||
}, | ||
"source_interface": "inside" | ||
} | ||
}, | ||
"destination": { | ||
"address": "10.0.1.20", | ||
"bytes": 238, | ||
"ip": "10.0.1.20", | ||
"packets": 1, | ||
"port": 53 | ||
}, | ||
"device": { | ||
"manufacturer": "Microsoft", | ||
"model": { | ||
"name": "Windows11" | ||
} | ||
}, | ||
"ecs": { | ||
"version": "8.17.0" | ||
}, | ||
"event": { | ||
"action": "connection-finished", | ||
"category": [ | ||
"network" | ||
], | ||
"code": "430003", | ||
"duration": 0, | ||
"end": "2025-09-01T12:35:00.000Z", | ||
"kind": "event", | ||
"original": "2025-09-01T12:00:00Z firepower : %FTD-6-430003: EventPriority: Low, DeviceUUID: d697c8ca-9fe4-43e6-aeb5-33e277e5ffea, InstanceID: 11, FirstPacketSecond: 2025-09-01T12:35:00Z, ConnectionID: 39416, AccessControlRuleAction: Trust, SrcIP: 10.0.100.30, DstIP: 10.0.1.20, SrcPort: 56799, DstPort: 53, Protocol: udp, IngressInterface: inside, EgressInterface: outside, SourceSecurityGroup: SGT_TEST_GROUP, SourceSecurityGroupTag: 2003, SourceSecurityGroupType: Session Directory, DestinationIP_DynamicAttribute: APIC_EPG_TEST_GROUP, IngressVRF: Global, EgressVRF: Global, Endpoint Profile: Workstation:Microsoft-Workstation:Windows11-Workstation, ACPolicy: ACP-Access, AccessControlRuleName: Test-Rule-1, Prefilter Policy: Default Prefilter Policy, User: testuser, Client: DNS, ApplicationProtocol: DNS, ConnectionDuration: 0, InitiatorPackets: 1, ResponderPackets: 1, InitiatorBytes: 31, ResponderBytes: 238, NAPPolicy: Balanced Security and Connectivity", | ||
"outcome": "success", | ||
"severity": 6, | ||
"start": "2025-09-01T12:35:00.000Z", | ||
"timezone": "UTC", | ||
"type": [ | ||
"connection", | ||
"end", | ||
"allowed" | ||
] | ||
}, | ||
"host": { | ||
"hostname": "firepower", | ||
"type": "Microsoft" | ||
}, | ||
"log": { | ||
"level": "informational" | ||
}, | ||
"network": { | ||
"application": "dns", | ||
"bytes": 269, | ||
"community_id": "1:xlmEboTK1cVSycaPD+f1Ii6nxMg=", | ||
"iana_number": "17", | ||
"protocol": "dns", | ||
"transport": "udp" | ||
}, | ||
"observer": { | ||
"egress": { | ||
"interface": { | ||
"name": "outside" | ||
} | ||
}, | ||
"hostname": "firepower", | ||
"ingress": { | ||
"interface": { | ||
"name": "inside" | ||
} | ||
}, | ||
"product": "ftd", | ||
"type": "idps", | ||
"vendor": "Cisco" | ||
}, | ||
"related": { | ||
"hosts": [ | ||
"firepower" | ||
], | ||
"ip": [ | ||
"10.0.100.30", | ||
"10.0.1.20" | ||
], | ||
"user": [ | ||
"testuser" | ||
] | ||
}, | ||
"rule": { | ||
"name": "Test-Rule-1", | ||
"ruleset": "ACP-Access" | ||
}, | ||
"source": { | ||
"address": "10.0.100.30", | ||
"bytes": 31, | ||
"ip": "10.0.100.30", | ||
"packets": 1, | ||
"port": 56799 | ||
}, | ||
"tags": [ | ||
"preserve_original_event" | ||
], | ||
"user": { | ||
"id": "testuser", | ||
"name": "testuser" | ||
} | ||
}, | ||
{ | ||
"@timestamp": "2025-09-01T14:00:03.000Z", | ||
"cisco": { | ||
"ftd": { | ||
"destination_interface": "outside", | ||
"rule_name": [ | ||
"ACP-Management", | ||
"Default Deny" | ||
], | ||
"security": { | ||
"endpoint_profile": "Invalid ID" | ||
}, | ||
"security_event": { | ||
"ac_policy": "ACP-Management", | ||
"access_control_rule_action": "Block", | ||
"access_control_rule_name": "Default Deny", | ||
"destination_security_group": "9", | ||
"destination_security_group_tag": "9", | ||
"dst_ip": "10.0.1.20", | ||
"dst_port": 22, | ||
"egress_interface": "outside", | ||
"first_packet_second": "2025-09-01T14:00:03Z", | ||
"ingress_interface": "inside", | ||
"initiator_bytes": 70, | ||
"initiator_packets": 1, | ||
"nap_policy": "Balanced Security and Connectivity", | ||
"prefilter_policy": "Management Prefilter Policy", | ||
"protocol": "tcp", | ||
"responder_bytes": 0, | ||
"responder_packets": 0, | ||
"source_security_group": "2005", | ||
"source_security_group_tag": "2005", | ||
"source_security_group_type": "Session Directory", | ||
"src_ip": "10.0.100.30", | ||
"src_port": 56799 | ||
}, | ||
"source_interface": "inside" | ||
} | ||
}, | ||
"destination": { | ||
"address": "10.0.1.20", | ||
"bytes": 0, | ||
"ip": "10.0.1.20", | ||
"packets": 0, | ||
"port": 22 | ||
}, | ||
"ecs": { | ||
"version": "8.17.0" | ||
}, | ||
"event": { | ||
"action": "connection-started", | ||
"category": [ | ||
"network" | ||
], | ||
"code": "430002", | ||
"kind": "event", | ||
"original": "2025-09-01T14:00:00Z firepower : %FTD-6-430002: EventPriority: Low, DeviceUUID: d697c8ca-9fe4-43e6-aeb5-33e277e5ffea, InstanceID: 4, FirstPacketSecond: 2025-09-01T14:00:03Z, ConnectionID: 36584, AccessControlRuleAction: Block, SrcIP: 10.0.100.30, DstIP: 10.0.1.20, SrcPort: 56799, DstPort: 22, Protocol: tcp, IngressInterface: inside, EgressInterface: outside, SourceSecurityGroup: 2005, SourceSecurityGroupTag: 2005, DestinationSecurityGroup: 9, DestinationSecurityGroupTag: 9, SourceSecurityGroupType: Session Directory, DestinationSecurityGroupType: SXP, IngressVRF: Global, EgressVRF: Global, Endpoint Profile: Invalid ID, ACPolicy: ACP-Management, AccessControlRuleName: Default Deny, Prefilter Policy: Management Prefilter Policy, InitiatorPackets: 1, ResponderPackets: 0, InitiatorBytes: 70, ResponderBytes: 0, NAPPolicy: Balanced Security and Connectivity", | ||
"outcome": "success", | ||
"severity": 6, | ||
"start": "2025-09-01T14:00:03Z", | ||
"timezone": "UTC", | ||
"type": [ | ||
"connection", | ||
"start", | ||
"denied" | ||
] | ||
}, | ||
"host": { | ||
"hostname": "firepower" | ||
}, | ||
"log": { | ||
"level": "informational" | ||
}, | ||
"network": { | ||
"bytes": 70, | ||
"community_id": "1:jcSnhrPf/GVREflEdymeibE8U/A=", | ||
"iana_number": "6", | ||
"transport": "tcp" | ||
}, | ||
"observer": { | ||
"egress": { | ||
"interface": { | ||
"name": "outside" | ||
} | ||
}, | ||
"hostname": "firepower", | ||
"ingress": { | ||
"interface": { | ||
"name": "inside" | ||
} | ||
}, | ||
"product": "ftd", | ||
"type": "idps", | ||
"vendor": "Cisco" | ||
}, | ||
"related": { | ||
"hosts": [ | ||
"firepower" | ||
], | ||
"ip": [ | ||
"10.0.100.30", | ||
"10.0.1.20" | ||
] | ||
}, | ||
"rule": { | ||
"name": "Default Deny", | ||
"ruleset": "ACP-Management" | ||
}, | ||
"source": { | ||
"address": "10.0.100.30", | ||
"bytes": 70, | ||
"ip": "10.0.100.30", | ||
"packets": 1, | ||
"port": 56799 | ||
}, | ||
"tags": [ | ||
"preserve_original_event" | ||
] | ||
}, | ||
{ | ||
"ecs": { | ||
"version": "8.17.0" | ||
}, | ||
"event": { | ||
"severity": 7, | ||
"timezone": "UTC" | ||
}, | ||
"log": { | ||
"level": "debug" | ||
}, | ||
"observer": { | ||
"product": "ftd", | ||
"type": "idps", | ||
"vendor": "Cisco" | ||
}, | ||
"tags": [ | ||
"preserve_original_event" | ||
] | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 3.11.0 since we are adding support for new types in this?