-
Notifications
You must be signed in to change notification settings - Fork 499
Pleasant Password Server extraction improvements #15666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a reference for the changes here?
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Duplicated - User <[email protected]> duplicated entry <TOP/SECRET/PASSWORD> 127.0.0.1 23/01 14:05:54.450 | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the name from <PASSWORD> to <PASSWORD2> changing the notes | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the name from <PASSWORD> to <PASSWORD2> changing the username from <entry_username> to <entry_username2> changing the password changing the notes changing the expiry date from <> to <2027-09-23 00:00> | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the username from <entry_username> to <entry_username2> changing the password changing the expiry date from <> to <2027-10-02 08:00> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final new line.
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Duplicated - User <[email protected]> duplicated entry <TOP/SECRET/PASSWORD> 127.0.0.1 23/01 14:05:54.450 | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the name from <PASSWORD> to <PASSWORD2> changing the notes | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the name from <PASSWORD> to <PASSWORD2> changing the username from <entry_username> to <entry_username2> changing the password changing the notes changing the expiry date from <> to <2027-09-23 00:00> | ||
<134>Jan 23 14:05:54 SRV-PPS-001 Pleasant Password Server:192.168.1.3 - [email protected] - - Success - Entry Updated - User <[email protected]> updated entry <TOP/SECRET/PASSWORD> changing the username from <entry_username> to <entry_username2> changing the password changing the expiry date from <> to <2027-10-02 08:00> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final new line.
I am not quite sure what you mean. |
Co-authored-by: Dan Kortschak <[email protected]>
The changes depend on an understanding of the expected layout of the data. It would be nice to have a reference for that for future maintenance. |
We have added the following fields and why: event.reason: pps.* pps.entry.* pps.entry.path pps.entry.reason pps.entry.name pps.entry.target.name pps.entry.username pps.entry.target.username Why we didn't put all the entry information directly into pps.* is basically to anticipate that maybe in the future other fields could become important that would not mix well with the entry fields. |
Is there a reference for the field syntax in the log lines that we are consuming? |
Proposed commit message
Improvements to the extraction of logfiles from the pleasant password server.
Added new proprietary pps fields for password entry information eg. username in a password entry changed (not to be confused with the username of a person who initiated the change)
Checklist
changelog.yml
file.Author's Checklist
I have noticed that the logfiles have a maybe important inforamtion after "changing the".
For example:
I propose to extract this information.
But grok is not a good option for this since these values are very dynamic hence would make a huge list of groks for every possible case.
Maybe someone could ruby script this for me?
Or any other cool ideas?
There is also an error message in the build that does not seem to stem from this pull request: