Skip to content

Conversation

@florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Nov 14, 2025

This PR:

  • /!\ is co-authored using AI
  • updates the logic of the tool so that PRs released in multiple versions show for each version they were released in instead of being filtered out
  • adds a safeguard warning when a PR has several labels belonging to the same minor version as in this case we need to check that it has not been released in a previous patch of that same minor
  • removes the step for selecting unreleased versions

Tested locally to check that the updated behaviour works as expected ✅:

  • for any given selected/specified stack version for kibana/security/endpoint/obs, the right PRs are retrieved regardless of other versions they might have been backported to as well
  • serverless release notes look unaffected by these changes
image image

Fixes: #50
Fixes the behavior raised in https://elastic.slack.com/archives/C0JF80CJZ/p1763136763466579

@florent-leborgne
Copy link
Contributor Author

@Ikuni17 could you take a look? 🙏

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce! A couple comments. Note: I did not test this PR.

Can you update the documentation in https://github.com/elastic/kibana-release-notes/blob/d1ab661cd05ccabaa5a5607bef137c1198d580ba/src/pages/release-notes/wizard.tsx#L326-327

@florent-leborgne
Copy link
Contributor Author

Can you update the documentation in https://github.com/elastic/kibana-release-notes/blob/d1ab661cd05ccabaa5a5607bef137c1198d580ba/src/pages/release-notes/wizard.tsx#L326-327

Actually I've removed this wizard step as it is not useful with the new expected behavior in my latest commit

@lcawl
Copy link
Contributor

lcawl commented Nov 14, 2025

My concern would be if this change makes the Kibana release notes have different behaviour than the other products' docs. [edit] It looks like Elasticsearch is following this same pattern, e.g. I see that elastic/elasticsearch#137222 appears in the 9.1.7 and 9.2.1 sections of https://www.elastic.co/docs/release-notes/elasticsearch, as well as in https://www.elastic.co/guide/en/elasticsearch/reference/8.19/release-notes-8.19.7.html

I wondered how this overlapped with the exclusion of PRs that have backport labels per

excludedLabels: ['release_note:skip', 'Team:Docs', 'reverted', 'backport'],

... but after a quick test locally with a PR like elastic/kibana#242691 it does show up in the 9.1.8 release notes (but its backport PR elastic/kibana#242721 does not), which I think is working as hoped.

@florent-leborgne
Copy link
Contributor Author

florent-leborgne commented Nov 15, 2025

@lcawl it's been consistently requested for multiple teams. I think ES does it, and even for Kibana/solutions we've been doing it as well (or trying to as it appears we missed some PRs) for some months.

I wondered how this overlapped with the exclusion of PRs that have backport labels

This is still the desired behavior - as PRs with the backport labels will have an original PR with the actual labels that we need for the tool (release_note:category, team/feature labels, version labels), while backport PRs don't.
This PR here doesn't change this

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, nice work! I was always confused about picking those extra versions and wanted to fix this.

I pushed a few small commits to refactor and add tests
abec88e...cc2052f

I ran everything locally and LGTM. If you could quickly rerun my changes locally incase I missed something and then merge.

@florent-leborgne
Copy link
Contributor Author

Thank you @Ikuni17!! Tested locally and works fine.

I think I lost some permissions on this repo as I'm not able to trigger the CI nor merge or select reviewers.

If you don't mind doing it for me or @lcawl if you still can. :)

@Ikuni17
Copy link
Contributor

Ikuni17 commented Nov 19, 2025

@Ikuni17 Ikuni17 merged commit acb8a2f into elastic:main Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some 9.0+ issues are sometimes not picked up while they should

4 participants