[Profiling] Add colors for new frame types (process name, thread name, root) #204977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
added
release_note:enhancement
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
inge4pres
approved these changes
Dec 23, 2024
MiriamAparicio
approved these changes
Dec 24, 2024
rockdaboot
force-pushed
the
flamegraph-executable-name
branch
2 times, most recently
from
d0a4cf4 to
1758e7a
Compare
rockdaboot
force-pushed
the
flamegraph-executable-name
branch
from
d9acea6 to
14391a0
Compare
rockdaboot
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @rockdaboot |
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…, root) (elastic#204977) ## Summary This PR is a pre-requisite for adding aggregation by process name and by thread name to the Universal Profiling flamegraph view. It adds three artificial node types to the flamegraph including color codes. As a side-effect, the root node now has its own color code. Previously, it (accidentally) used the color code of "unknown" type frames. The PR is backwards compatible, so it doesn't change anything in the UI when connecting with current Elasticsearch. As soon as [the PR for ES](elastic/elasticsearch#119115) is merged, the new aggregations show up.
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
May 2, 2025
…, root) (elastic#204977) ## Summary This PR is a pre-requisite for adding aggregation by process name and by thread name to the Universal Profiling flamegraph view. It adds three artificial node types to the flamegraph including color codes. As a side-effect, the root node now has its own color code. Previously, it (accidentally) used the color code of "unknown" type frames. The PR is backwards compatible, so it doesn't change anything in the UI when connecting with current Elasticsearch. As soon as [the PR for ES](elastic/elasticsearch#119115) is merged, the new aggregations show up. (cherry picked from commit bc5d8db)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
added a commit
that referenced
this pull request
May 6, 2025
…ad name, root) (#204977) (#219979) # Backport This will backport the following commits from `main` to `8.19`: - [[Profiling] Add colors for new frame types (process name, thread name, root) (#204977)](#204977) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Rühsen","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:24:43Z","message":"[Profiling] Add colors for new frame types (process name, thread name, root) (#204977)\n\n## Summary\r\nThis PR is a pre-requisite for adding aggregation by process name and by\r\nthread name to the Universal Profiling flamegraph view.\r\n\r\nIt adds three artificial node types to the flamegraph including color\r\ncodes.\r\n\r\nAs a side-effect, the root node now has its own color code. Previously,\r\nit (accidentally) used the color code of \"unknown\" type frames.\r\n\r\nThe PR is backwards compatible, so it doesn't change anything in the UI\r\nwhen connecting with current Elasticsearch.\r\nAs soon as [the PR for\r\nES](elastic/elasticsearch#119115) is merged, the\r\nnew aggregations show up.","sha":"bc5d8db237bdef481de9e4ce37d9e460755ae418","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Profiling] Add colors for new frame types (process name, thread name, root)","number":204977,"url":"https://github.com/elastic/kibana/pull/204977","mergeCommit":{"message":"[Profiling] Add colors for new frame types (process name, thread name, root) (#204977)\n\n## Summary\r\nThis PR is a pre-requisite for adding aggregation by process name and by\r\nthread name to the Universal Profiling flamegraph view.\r\n\r\nIt adds three artificial node types to the flamegraph including color\r\ncodes.\r\n\r\nAs a side-effect, the root node now has its own color code. Previously,\r\nit (accidentally) used the color code of \"unknown\" type frames.\r\n\r\nThe PR is backwards compatible, so it doesn't change anything in the UI\r\nwhen connecting with current Elasticsearch.\r\nAs soon as [the PR for\r\nES](elastic/elasticsearch#119115) is merged, the\r\nnew aggregations show up.","sha":"bc5d8db237bdef481de9e4ce37d9e460755ae418"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204977","number":204977,"mergeCommit":{"message":"[Profiling] Add colors for new frame types (process name, thread name, root) (#204977)\n\n## Summary\r\nThis PR is a pre-requisite for adding aggregation by process name and by\r\nthread name to the Universal Profiling flamegraph view.\r\n\r\nIt adds three artificial node types to the flamegraph including color\r\ncodes.\r\n\r\nAs a side-effect, the root node now has its own color code. Previously,\r\nit (accidentally) used the color code of \"unknown\" type frames.\r\n\r\nThe PR is backwards compatible, so it doesn't change anything in the UI\r\nwhen connecting with current Elasticsearch.\r\nAs soon as [the PR for\r\nES](elastic/elasticsearch#119115) is merged, the\r\nnew aggregations show up.","sha":"bc5d8db237bdef481de9e4ce37d9e460755ae418"}}]}] BACKPORT--> Co-authored-by: Tim Rühsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a pre-requisite for adding aggregation by process name and by thread name to the Universal Profiling flamegraph view.
It adds three artificial node types to the flamegraph including color codes.
As a side-effect, the root node now has its own color code. Previously, it (accidentally) used the color code of "unknown" type frames.
The PR is backwards compatible, so it doesn't change anything in the UI when connecting with current Elasticsearch.
As soon as the PR for ES is merged, the new aggregations show up.