Skip to content

[Profiling] Add colors for new frame types (process name, thread name, root) #204977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[Profiling] Add colors for new frame types (process name, thread name, root) #204977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14391a0
[Profiling] Add colors for new frame types (exe name, thread name, root)
rockdaboot Dec 18, 2024
1b47745
Rename Executable to Process
rockdaboot Jan 8, 2025
875cd84
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ export enum FrameType {
DotNET,
ErrorFlag = 0x80,
Error = 0xff,

// Artificial frame types for grouping, set by the ES profiling plugin
Root = 0x100,
ProcessName = 0x101,
ThreadName = 0x102,
}

const frameTypeDescriptions = {
Expand All @@ -53,6 +58,9 @@ const frameTypeDescriptions = {
[FrameType.DotNET]: '.NET',
[FrameType.ErrorFlag]: 'ErrorFlag',
[FrameType.Error]: 'Error',
[FrameType.Root]: 'Root',
[FrameType.ProcessName]: 'Process', // Due to OTEL semconv issues, "process name" is currently more correct than "executable name"
[FrameType.ThreadName]: 'Thread',
};

export function isErrorFrame(ft: FrameType): boolean {
Expand Down
7 changes: 7 additions & 0 deletions x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ import { FrameType, normalizeFrameType } from '@kbn/profiling-utils';
*
* Taken originally from prodfiler_ui/src/helpers/Pixi/frameTypeToColors.tsx
*/
const RED = 0xfd8484;
const ORANGE = 0xffaa00;
const YELLOW = 0xe1e100;

export const FRAME_TYPE_COLOR_MAP = {
[FrameType.Unsymbolized]: [0xfd8484, 0xfd9d9d, 0xfeb5b5, 0xfecece],
[FrameType.Python]: [0xfcae6b, 0xfdbe89, 0xfdcea6, 0xfedfc4],
Expand All @@ -42,6 +46,9 @@ export const FRAME_TYPE_COLOR_MAP = {
[FrameType.DotNET]: [0x6c60e1, 0x8075e5, 0x948be9, 0xa8a0ed],
[FrameType.ErrorFlag]: [0x0, 0x0, 0x0, 0x0], // This is a special case, it's not a real frame type
[FrameType.Error]: [0xfd8484, 0xfd9d9d, 0xfeb5b5, 0xfecece],
[FrameType.Root]: [RED, RED, RED, RED],
[FrameType.ProcessName]: [ORANGE, ORANGE, ORANGE, ORANGE],
[FrameType.ThreadName]: [YELLOW, YELLOW, YELLOW, YELLOW],
};

export function frameTypeToRGB(frameType: FrameType, x: number): number {
Expand Down
Loading