Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 19, 2025

Summary

This PR:

  • updates the doc link service to use the appropriate URLs for the new doc system
  • adds a server.publicBaseUrl keyword in the service and updates public_base_url.tsx to use it, since the hard-coded fragment will not work when we shift to the new docs site.

This update is accomplished by taking our current (work in progress) list of redirects and using it to replace the values in get_doc_links.ts via a python script. It does not check the validity of the existing anchors in the URLs.

Refer to #215084 (comment) for discussion about the build failures.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl
Copy link
Contributor Author

lcawl commented Mar 20, 2025

/ci

@lcawl lcawl marked this pull request as ready for review March 20, 2025 03:52
@lcawl lcawl requested review from a team as code owners March 20, 2025 03:52
@lcawl lcawl added WIP Work in progress Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs labels Mar 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl added v9.1.0 v9.0.1 backport:version Backport to applied version labels labels Mar 20, 2025
@lcawl lcawl marked this pull request as draft March 20, 2025 21:39
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 20, 2025

💔 Build Failed

Failed CI Steps

History

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢
Still in draft mode but I trust it's okay to approve.

@lcawl
Copy link
Contributor Author

lcawl commented Apr 30, 2025

This PR has been replaced by #219657 and the rest of the PRs linked from #217722

@lcawl lcawl closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.1.0 WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants