Skip to content

Conversation

@afharo
Copy link
Member

@afharo afharo commented Apr 4, 2025

Summary

Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584.

We should be able to remove all usages of // @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584.

Checklist

@afharo afharo self-assigned this Apr 4, 2025
@afharo afharo changed the title [ES 9.0] (Remove body workaround) @elastic/fleet [ES 9.0] Remove body workaround (@elastic/fleet) Apr 4, 2025
@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team elasticsearch-js-9 Feature:elasticsearch labels Apr 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / EPM template updateCurrentWriteIndices should fill constant keywords from previous mappings
  • [job] [logs] Jest Tests #2 / EPM template updateCurrentWriteIndices should fill constant keywords from previous mappings
  • [job] [logs] Jest Tests #2 / EPM template updateCurrentWriteIndices should not error when previous mappings are not found
  • [job] [logs] Jest Tests #2 / EPM template updateCurrentWriteIndices should not error when previous mappings are not found
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) should not set index:false on @timestamp field
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) should not set index:false on @timestamp field
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) should update index template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) should update index template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template number fields
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template number fields
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template other fields
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy does not exist (create) updates component template other fields
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed should not remove index:false from a field that has it in package spec
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed should not remove index:false from a field that has it in package spec
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed should update index template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed should update index template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed updates component template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed updates component template
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed updates component template number fields
  • [job] [logs] Jest Tests #2 / experimental_datastream_features when package policy exists (update) when opt in status is changed updates component template number fields
  • [job] [logs] Jest Tests #2 / test transform install can install new versions and removes older version when fleet_transform_version increased
  • [job] [logs] Jest Tests #2 / test transform install can install new versions and removes older version when fleet_transform_version increased
  • [job] [logs] Jest Tests #2 / test transform install can install new versions and removes older version when upgraded from old json schema to new yml schema
  • [job] [logs] Jest Tests #2 / test transform install can install new versions and removes older version when upgraded from old json schema to new yml schema
  • [job] [logs] Jest Tests #2 / test transform install creates index and component templates even if no manifest.yml
  • [job] [logs] Jest Tests #2 / test transform install creates index and component templates even if no manifest.yml
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

✅ unchanged

History

cc @afharo

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo marked this pull request as ready for review April 7, 2025 15:59
@afharo afharo requested a review from a team as a code owner April 7, 2025 15:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo merged commit 3ab31d3 into elastic:main Apr 8, 2025
10 checks passed
@afharo afharo deleted the es-9.0/remove-body-workaround/elastic/fleet branch April 8, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting elasticsearch-js-9 Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants