[SB] Fix graph layout stories #217766
Merged
[SB] Fix graph layout stories #217766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
added
release_note:skip
kfirpeled
approved these changes
Apr 16, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @Ikuni17 |
Contributor
|
Starting backport for target branches: 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <[email protected]> (cherry picked from commit a7796cd)
Contributor
Ikuni17
added
backport:prev-minor
and removed
backport:version
Contributor
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <[email protected]> (cherry picked from commit a7796cd)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 17, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <[email protected]>
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Apr 18, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[SB] Fix graph layout stories (#217766)](#217766) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T16:59:08Z","message":"[SB] Fix graph layout stories (#217766)\n\n## Summary\n\nThis fixes the graph layout stories not rendering properly after\n#214684. Open to a better or preferred fix as I'm not familiar with\nthese components.\n\nThere was a console warning:\n```js\n[React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004\n```\n\n[Storybook preview\nlink](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock)\n\n---------\n\nCo-authored-by: Kfir Peled <[email protected]>","sha":"a7796cd0d00453f67d0f5c4366352c53d6c63131","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:build-storybooks","backport:version","v9.1.0","v8.19.0"],"title":"[SB] Fix graph layout stories","number":217766,"url":"https://github.com/elastic/kibana/pull/217766","mergeCommit":{"message":"[SB] Fix graph layout stories (#217766)\n\n## Summary\n\nThis fixes the graph layout stories not rendering properly after\n#214684. Open to a better or preferred fix as I'm not familiar with\nthese components.\n\nThere was a console warning:\n```js\n[React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004\n```\n\n[Storybook preview\nlink](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock)\n\n---------\n\nCo-authored-by: Kfir Peled <[email protected]>","sha":"a7796cd0d00453f67d0f5c4366352c53d6c63131"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217766","number":217766,"mergeCommit":{"message":"[SB] Fix graph layout stories (#217766)\n\n## Summary\n\nThis fixes the graph layout stories not rendering properly after\n#214684. Open to a better or preferred fix as I'm not familiar with\nthese components.\n\nThere was a console warning:\n```js\n[React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004\n```\n\n[Storybook preview\nlink](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock)\n\n---------\n\nCo-authored-by: Kfir Peled <[email protected]>","sha":"a7796cd0d00453f67d0f5c4366352c53d6c63131"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Brad White <[email protected]>
kibanamachine
added
v9.0.1
and removed
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the graph layout stories not rendering properly after #214684. Open to a better or preferred fix as I'm not familiar with these components.
There was a console warning:
Storybook preview link