-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution][Endpoint] Update response action creation so that it store policy information when action is created #218175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
paul-tavares
merged 49 commits into
elastic:main
from
paul-tavares:task/olm-11225-store-policy-id-in-action-request-for-spaces
Apr 23, 2025
Merged
Changes from 42 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
f30a292
Added new abstract method `fetchAgentPolicyInfo()` to base class and …
paul-tavares 052bb8b
Added `spaceId` option to Response Actions clients and adjusted stori…
paul-tavares 7366645
Fleet: add log when running external callback fails
paul-tavares 002f702
Merge remote-tracking branch 'upstream/main' into task/olm-11225-stor…
paul-tavares b3482d0
Revert "Fleet: add log when running external callback fails"
paul-tavares b70f3dc
Add `fetchAgentPolicyInfo()` to Endpoint response actions client
paul-tavares 6b5f953
Implementation of `fetchAgentPolicyInfo()` for S1
paul-tavares 8e18f9e
remove comment
paul-tavares f597e67
Added `fetchFleetInfoForAgents()` to base class and refactored S1 and…
paul-tavares 3444532
Added `fetchAgentPolicyInfo()` implementation to MS defender client
paul-tavares e2f3b37
Added implementation of `fetchAgentPolicyInfo()` to crowdstrike
paul-tavares a06b59f
Changed S1 and MS Defender run scripts to include the space id in the…
paul-tavares 62746f7
Added new method `getIntegrationNamespaces()` to internal fleet services
paul-tavares 46ad24f
Refactor response actions clients to ensure policy info. is retrieved…
paul-tavares f9e1fe1
Fix generator and tests to include new `agent.policy`
paul-tavares 04e0198
Tests for `getIntegrationNamespaces()`
paul-tavares d710fba
Fix test for `fetchActionRequests()`
paul-tavares 151ff88
Test for base class write of action to index
paul-tavares 8b3865b
Added additional mock generators for sentinelOne
paul-tavares 7f9ff2d
Added support for index patterns in `applyEsClientSearchMock()` utility
paul-tavares 5ae36a5
Update mocks
paul-tavares 48f024d
tests for S1 when spaces is enabled
paul-tavares 9c62359
tests for endpoint write of request when spaces is enabled
paul-tavares 6961214
Tests for MS Defender
paul-tavares c3310ce
Tests for crowdstrike
paul-tavares f3989cb
Add missing test to MS Defender client
paul-tavares 6cc71e9
Merge remote-tracking branch 'upstream/main' into task/olm-11225-stor…
paul-tavares a735127
Improvement to wrap errors utility
paul-tavares 1283e07
Adjustments to HTTP error codes and messages
paul-tavares fdb9f36
Adjust mock utility use of `fromKueryExpression()`
paul-tavares 18137cf
Clean up utils.mock.ts
paul-tavares 929ce46
Fix failing tests
paul-tavares fa8f49d
Merge branch 'main' into task/olm-11225-store-policy-id-in-action-req…
paul-tavares af22a7a
Change API route error handler to handle `500` errors instead of dele…
paul-tavares 7d36a91
Add additional validation to external EDR clients
paul-tavares 317971a
Merge remote-tracking branch 'origin/task/olm-11225-store-policy-id-i…
paul-tavares 08c7630
Fix in S1
paul-tavares 6a3d122
Fix test
paul-tavares df5507e
Merge branch 'main' into task/olm-11225-store-policy-id-in-action-req…
paul-tavares a90a129
Apply suggestions from code review
paul-tavares 5241583
Merge remote-tracking branch 'upstream/main' into task/olm-11225-stor…
paul-tavares 47daa45
Update type to use `unknown`
paul-tavares d1b6b15
Fix spelling and tests
paul-tavares e029581
Merge branch 'main' into task/olm-11225-store-policy-id-in-action-req…
paul-tavares 057068f
Merge branch 'main' into task/olm-11225-store-policy-id-in-action-req…
paul-tavares 6f5407e
Apply suggestions from code review
paul-tavares 28fcab4
Update x-pack/solutions/security/plugins/security_solution/common/end…
paul-tavares a07ed42
Merge branch 'main' into task/olm-11225-store-policy-id-in-action-req…
paul-tavares 76f9d08
Fix insights tests
paul-tavares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇🏼 Thanks for sorting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
FYI:
I actually did not sort it on purpose. I only moved
cloud.instance.idup so that it is the first one we try to find in MS documents. thats because I'm still not 100% sure of the other fields defined below because we never really set up the M365 integration. I got these values from an Env. that Raquel has where she did setup M365.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Well, sorted values are always nice to maintain. 🌞