-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add origin configuration to authc providers #239993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin configuration to authc providers #239993
Conversation
🔍 Preview links for changed docs |
…filter available providers based on the origin configuration and the current browser window origin. Also filtered available providers based on the origin header and the configured provider origin properties # Conflicts: # x-pack/platform/plugins/shared/security/server/authentication/authenticator.ts
…ge message to use translate function
37fa181 to
34bb5d3
Compare
….com:rgodfrey-elastic/kibana into feature/add-origin-config-to-authc-providers
|
Pinging @elastic/kibana-security (Team:Security) |
Co-authored-by: florent-leborgne <[email protected]>
|
ACK: will review later today or tomorrow, sorry for the delay! |
azasypkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I've left just a few questions and nits.
...orm/plugins/shared/security/public/authentication/login/components/login_form/login_form.tsx
Outdated
Show resolved
Hide resolved
...lugins/shared/security/public/authentication/login/components/login_form/login_form.test.tsx
Outdated
Show resolved
Hide resolved
...lugins/shared/security/public/authentication/login/components/login_form/login_form.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/security/server/authentication/providers/base.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/security/server/authentication/authenticator.ts
Outdated
Show resolved
Hide resolved
...lugins/shared/security/public/authentication/login/components/login_form/login_form.test.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
azasypkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally - everything works as expected, thanks! Would you also mind updating the Release Notes section in the issue description to better align with your updates in the doc (these are being used to compile release notes for every release)?
...lugins/shared/security/public/authentication/login/components/login_form/login_form.test.tsx
Outdated
Show resolved
Hide resolved
...lugins/shared/security/public/authentication/login/components/login_form/login_form.test.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
florent-leborgne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs LGTM, thanks!
Closes [109525](elastic#109525) ## Summary - Added origin configuration to authc providers. - Changed login form to hide providers based on the origin configuration and the current browser window origin. - Filtered providers on the back end based on the origin header and the configured provider origin properties. - Origin configuration is optional and can be one value or an array of values. - All values provided in the origin config must be a valid URI - An error is displayed in the UI if there are no valid auth providers for the domain ### Example 1 ``` xpack.security.authc.providers: basic.basic1: order: 0 origin: [http://127.0.0.1:5601, http://localhost:5601, https://elastic.com] saml.saml1: order: 1 realm: saml1 origin: http://127.0.0.1:5601 saml.saml2: order: 2 realm: saml2 origin: http://localhost:5601 saml.saml3: order: 3 realm: saml3 origin: [http://127.0.0.1:5601, http://localhost:5601, https://elastic.com] saml.saml4: order: 4 realm: saml4 ``` <img width="735" height="585" alt="image" src="https://github.com/user-attachments/assets/d691f692-6470-4d59-aba1-bc598b4b49a2" /> <img width="725" height="597" alt="image" src="https://github.com/user-attachments/assets/28a61462-ef00-484f-b2c9-1816bc50fc54" /> ### Example 2 ``` xpack.security.authc.providers: basic.basic1: order: 0 origin: [http://127.0.0.1:5601, https://elastic.com] saml.saml1: order: 1 realm: saml1 origin: https://elastic.com ``` <img width="772" height="443" alt="image" src="https://github.com/user-attachments/assets/9c332a42-2a48-43ea-b4c5-0d9ab6660b6a" /> ## Release Notes Adds the ability to specify the origin(s) where an authentication provider will appear to users in the Login Selector UI. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: florent-leborgne <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
## Summary Added note about new `origin` setting available for authentication providers added with elastic/kibana#239993
Closes 109525
Summary
Example 1
Example 2
Release Notes
Adds the ability to specify the origin(s) where an authentication provider will appear to users in the Login Selector UI.