Skip to content

[Discover] Fix truncation for longer text in table #241440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+6 −0
Open

[Discover] Fix truncation for longer text in table #241440

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee2f8f3
add eui-textTruncate classname to in-table-search div
akowalska622 Oct 31, 2025
a0f4b87
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Oct 31, 2025
75cdde8
add truncation only for one line
akowalska622 Oct 31, 2025
969ef37
Merge branch 'discover-fix-one-line-truncation' of github.com:elastic…
akowalska622 Oct 31, 2025
060a78b
remove unused import
akowalska622 Oct 31, 2025
bd14d1a
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 3, 2025
6ddd39b
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 4, 2025
70e7b4a
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,6 +1475,12 @@ const componentStyles = {
'.unifiedDataTable__cell--expanded': {
backgroundColor: euiTheme.colors.backgroundBaseInteractiveSelect,
},
'.euiDataGridRowCell__content--defaultHeight > div': {
maxInlineSize: '100%',
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
},
Comment on lines +1478 to +1483
Copy link
Contributor

@davismcphee davismcphee Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the root cause of the issue may be that we wrap cell contents in a div which defaults to display: block, preventing the EUI styles from being inherited correctly. Instead of redefining the EUI styles here, what if we just change the wrapping element to a span in InTableSearchHighlightsWrapper so the styles are inherited correctly?

kibana/src/platform/packages/shared/kbn-data-grid-in-table-search/src/in_table_search_highlights_wrapper.tsx

Line 64 in faf0c28

return <div ref={cellValueRef}>{children}</div>;

I gave it a quick shot locally and it seemed to work as expected.

'.unifiedDataTable__cellValue': {
fontFamily: euiTheme.font.familyCode,
},
Expand Down