Skip to content

Conversation

@seialkali
Copy link
Contributor

Summary

This PR adds FTR test for the Getting Started page, as well as a fix for a bug that was picked up by the tests.

NOTE: I'm aware we should be moving over to Scout, but I thought it might be easier (for me at least) to get these tests up and running first and then convert them to Scout afterwards.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@seialkali seialkali requested a review from a team as a code owner October 31, 2025 11:19
@seialkali seialkali added the release_note:skip Skip the PR/issue when compiling release notes label Oct 31, 2025
@seialkali seialkali requested a review from a team as a code owner October 31, 2025 11:19
@seialkali seialkali added backport:skip This PR does not require backporting Team:Search v9.3.0 labels Oct 31, 2025
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/solutions/search/test/serverless/functional/configs/config.ts changes LGTM

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#9695

[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed.
[✅] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 25/25 tests passed.

see run history

@seialkali seialkali force-pushed the getting-started-ftr-page-object branch from bf04daf to e148107 Compare October 31, 2025 13:14
@seialkali seialkali requested a review from a team as a code owner October 31, 2025 13:14
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#9697

[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed.
[❌] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 23/25 tests passed.

see run history

@seialkali seialkali force-pushed the getting-started-ftr-page-object branch from e148107 to 19868e2 Compare October 31, 2025 16:45
@seialkali seialkali force-pushed the getting-started-ftr-page-object branch from 19868e2 to e3ab2e0 Compare October 31, 2025 16:49
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#9702

[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed.
[❌] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 0/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 31, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Search solution FF tests Search Getting Started page Solution Nav - Search Getting Started redirect flow redirects to Getting Started on first load
  • [job] [logs] FTR Configs #2 / Search solution FF tests Search Getting Started page Solution Nav - Search Getting Started redirect flow redirects to Getting Started on first load
  • [job] [logs] FTR Configs #60 / serverless search UI - feature flags Search Getting Started page as viewer Getting Started page interactions Explore the API clicking on search basics tutorial opens console
  • [job] [logs] FTR Configs #60 / serverless search UI - feature flags Search Getting Started page as viewer Getting Started redirect flow redirects to Getting Started on first load
  • [job] [logs] Scout: [ platform / discover_enhanced ] plugin / serverless-search - Discover app - saved searches - should unselect saved search when navigating to a 'new'

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchGettingStarted 268 267 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchGettingStarted 155.0KB 154.8KB -149.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchGettingStarted 6.1KB 6.5KB +465.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants