-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Search] FTR tests and fixes for Getting Started page #241442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
...earch/plugins/search_getting_started/public/components/tutorials/console_tutorials_group.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack/solutions/search/test/serverless/functional/configs/config.ts changes LGTM
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Show resolved
Hide resolved
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Show resolved
Hide resolved
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9695[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
bf04daf to
e148107
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9697[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
e148107 to
19868e2
Compare
19868e2 to
e3ab2e0
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9702[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Summary
This PR adds FTR test for the Getting Started page, as well as a fix for a bug that was picked up by the tests.
NOTE: I'm aware we should be moving over to Scout, but I thought it might be easier (for me at least) to get these tests up and running first and then convert them to Scout afterwards.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.The PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelinesReview the backport guidelines and apply applicablebackport:*labels.