[Data Streams] Remove api integration tests for index mode #242015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Index Management
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
Closing as it turns out the tests caught a bug in Es that was recently introduced in elastic/elasticsearch#137407. A fix was added with elastic/elasticsearch#137646. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241906
Fixes #241907
Summary
This PR removes the tests related to index mode as they are no longer relevant since the
index_modefield was added to theGET _data_streamAPI in elastic/elasticsearch#122486. Previously, theGET _data_streamAPI didn't haveindex_modein the response body so we would assume the index_mode based on cluster settings and the data stream name (if it islogs-*-*). Now that the index_mode field is there, it takes precedence so we don't have to make assumptions based on cluster settings, and so these tests are irrelevant. Also, they often create noise on Es promotions if the behavior in Es changes.