-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover][Unified Tabs] Rename "Tabs bar menu" to "Tabs menu" #243332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Unified Tabs] Rename "Tabs bar menu" to "Tabs menu" #243332
Conversation
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
src/platform/packages/shared/kbn-unified-tabs/src/components/tabs_bar_menu/tabs_bar_menu.tsx
Show resolved
Hide resolved
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
This reverts commit b7f8653.
…alska622/kibana into unified-tabs-change-tabs-bar-naming
davismcphee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Starting backport for target branches: 9.2 |
…ic#243332) (cherry picked from commit c620d11)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Related to [[Discover] Rename "Tabs bar menu" to "Tabs menu"](elastic/kibana#239420 (comment)) This pull request makes a minor update to the documentation for tab management in Discover. It reflects changes from [[Discover][Unified Tabs] Rename "Tabs bar menu" to "Tabs menu"](elastic/kibana#243332 (comment))
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…243332) (#243879) # Backport This will backport the following commits from `main` to `9.2`: - [[Discover][Unified Tabs] Rename "Tabs bar menu" to "Tabs menu" (#243332)](#243332) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ania Kowalska","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-21T17:13:53Z","message":"[Discover][Unified Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\" (#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.3.0","Feature:DiscoverTabs"],"title":"[Discover][Unified Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\"","number":243332,"url":"https://github.com/elastic/kibana/pull/243332","mergeCommit":{"message":"[Discover][Unified Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\" (#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/243332","number":243332,"mergeCommit":{"message":"[Discover][Unified Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\" (#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab"}}]}] BACKPORT--> Co-authored-by: Ania Kowalska <[email protected]>
Summary
Resolves #239420
This pull request refactors the "tabs bar menu" feature in the Unified Tabs component by renaming it to "tabs menu" throughout the codebase and updating all relevant references, props, and test IDs. The changes are focused on improving clarity and consistency in naming, without altering functionality.Eventually only the tooltip copy was changed within the PR. No code references were changed.
No functional behavior was changed - this is a pure renaming and refactoring for clarity and maintainability.
Documentation adjusted in: Rename "Tabs bar menu" to "Tabs menu"
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.