[Discover] Fix ToolbarSelector when clicking on tabs
#247836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpatticha
changed the title
ToolbarSeclector click handler ToolbarSelector click handler
kpatticha
changed the title
ToolbarSelector click handler ToolbarSelector when clicking on tabs
kpatticha
added
release_note:fix
backport:skip
…ic/obs-presentation-team to @elastic/obs-exploration-team
kpatticha
force-pushed
the
243535-popover-fix-with-tabs
branch
from
45d4d2b to
b583019
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
davismcphee
approved these changes
Jan 7, 2026
jennypavlova
approved these changes
Jan 7, 2026
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
The code LGTM, thanks for the fix 💯
| src/platform/packages/shared/shared-ux/storybook/mock @elastic/appex-sharedux | ||
| src/platform/packages/shared/shared-ux/table_persist @elastic/appex-sharedux | ||
| src/platform/packages/shared/shared-ux/toolbar_selector @elastic/obs-presentation-team | ||
| src/platform/packages/shared/shared-ux/toolbar_selector @elastic/obs-exploration-team |
Member
There was a problem hiding this comment.
I see we are still marked a reviewer, I guess after we merge this one it will be fixed :)
crespocarlos
approved these changes
Jan 7, 2026
devamanv
pushed a commit
to devamanv/kibana
that referenced
this pull request
Jan 12, 2026
## Summary Closes elastic#243535 Adds `EuiOutsideClickDetector` wrapper to properly close `ToolbarSelector` popover when user clicks outside, fixing issue where dropdowns persist when clicking on draggable tabs in Discover. ## Before <img width="1438" height="800" alt="image" src="https://github.com/user-attachments/assets/0102db09-19bc-4222-b414-9c7a92a4f0ad" /> ## After https://github.com/user-attachments/assets/dd32905c-ab70-4620-9bf2-caf4a6ef9ed4 --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #243535
Adds
EuiOutsideClickDetectorwrapper to properly closeToolbarSelectorpopoverwhen user clicks outside, fixing issue where dropdowns persist when clicking on draggable tabs in Discover.
Before
After
Screen.Recording.2026-01-05.at.6.38.29.PM.mov