Skip to content

Comments

[Entity Analytics] Add ability to access anonymization modal in entity highlight component#247887

Merged
ymao1 merged 3 commits intoelastic:mainfrom
ymao1:ea-247028
Jan 8, 2026
Merged

[Entity Analytics] Add ability to access anonymization modal in entity highlight component#247887
ymao1 merged 3 commits intoelastic:mainfrom
ymao1:ea-247028

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jan 5, 2026

Resolves #247028

Summary

The entity highlight component uses global anonymization settings that can be managed via the anonymization modal. Previously, we were allowing users to toggle anonymization on and off but were not allowing access to adjust the anonymization settings from this menu. This PR adds the ability to open the anonymization modal settings from the menu.

Note, the original issue description mentioned that these anonymization settings should not be shown in Agent Builder mode. While it is true that Agent Builder does not handle anonymization, the entity highlight does not directly use Agent Builder and so these anonymization settings should show up regardless of whether we're using Agent Builder or Classic AI Assistant. This comment is a better description of the issue.

To Verify

  1. Start ES and Kibana
  2. Generate some alerts using the security-documents-generator and run the risk scoring task
  3. Navigate to the Entity Analytics Overview and open the details flyout for an entity
  4. Click the hamburger menu and see that an "gear" icon is available (although the screenshot is old and shows an "eye")
Screenshot 2026-01-05 at 4 44 28 PM
  1. Click the icon and open the anonymization settings modal to customize anonymization settings
Screenshot 2026-01-05 at 4 46 55 PM

@ymao1 ymao1 self-assigned this Jan 5, 2026
@ymao1 ymao1 added backport:skip This PR does not require backporting Team:Entity Analytics Security Entity Analytics Team v9.4.0 backport:version Backport to applied version labels v9.3.0 release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This PR does not require backporting labels Jan 5, 2026
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #15 / Endpoint Exceptions with feature flag enabled @ess @serverless @skipInServerlessMKI Endpoint List API (deprecated): RBAC and Validation "before all" hook in "@ess @serverless @skipInServerlessMKI Endpoint List API (deprecated): RBAC and Validation"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.7MB 10.7MB +107.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 171.6KB 171.6KB -5.0B

cc @ymao1

@ymao1 ymao1 marked this pull request as ready for review January 6, 2026 00:17
@ymao1 ymao1 requested a review from a team as a code owner January 6, 2026 00:17
@ymao1 ymao1 requested a review from hop-dev January 6, 2026 00:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@ymao1 ymao1 requested a review from stephmilovic January 6, 2026 16:58
…ity_analytics/components/entity_details_flyout/components/entity_highlights_settings.tsx

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Jan 7, 2026

@elasticmachine merge upstream

@ymao1 ymao1 merged commit 4e40a02 into elastic:main Jan 8, 2026
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/20817982756

@ymao1 ymao1 deleted the ea-247028 branch January 8, 2026 13:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2026
…y highlight component (elastic#247887)

Resolves elastic#247028

## Summary

The entity highlight component uses global anonymization settings that
can be managed via the anonymization modal. Previously, we were allowing
users to toggle anonymization on and off but were not allowing access to
adjust the anonymization settings from this menu. This PR adds the
ability to open the anonymization modal settings from the menu.

Note, the original issue description mentioned that these anonymization
settings should not be shown in Agent Builder mode. While it is true
that Agent Builder does not handle anonymization, the entity highlight
does not directly use Agent Builder and so these anonymization settings
should show up regardless of whether we're using Agent Builder or
Classic AI Assistant. [This
comment](elastic#247028 (comment))
is a better description of the issue.

## To Verify

1. Start ES and Kibana
2. Generate some alerts using the `security-documents-generator` and run
the risk scoring task
3. Navigate to the Entity Analytics Overview and open the details flyout
for an entity
4. Click the hamburger menu and see that an "gear" icon is available
(although the screenshot is old and shows an "eye")
<img width="831" height="268" alt="Screenshot 2026-01-05 at 4 44 28 PM"
src="https://github.com/user-attachments/assets/e7b3d1a0-e4ab-4d16-b25c-47475d705315"
/>

5. Click the icon and open the anonymization settings modal to customize
anonymization settings
<img width="771" height="887" alt="Screenshot 2026-01-05 at 4 46 55 PM"
src="https://github.com/user-attachments/assets/b8895f32-f75b-4af9-835b-0cf8a5bbecf7"
/>

---------

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 4e40a02)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 8, 2026
… entity highlight component (#247887) (#248266)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Entity Analytics] Add ability to access anonymization modal in
entity highlight component
(#247887)](#247887)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2026-01-08T13:11:56Z","message":"[Entity
Analytics] Add ability to access anonymization modal in entity highlight
component (#247887)\n\nResolves
https://github.com/elastic/kibana/issues/247028\n\n## Summary\n\nThe
entity highlight component uses global anonymization settings that\ncan
be managed via the anonymization modal. Previously, we were
allowing\nusers to toggle anonymization on and off but were not allowing
access to\nadjust the anonymization settings from this menu. This PR
adds the\nability to open the anonymization modal settings from the
menu.\n\nNote, the original issue description mentioned that these
anonymization\nsettings should not be shown in Agent Builder mode. While
it is true\nthat Agent Builder does not handle anonymization, the entity
highlight\ndoes not directly use Agent Builder and so these
anonymization settings\nshould show up regardless of whether we're using
Agent Builder or\nClassic AI Assistant.
[This\ncomment](https://github.com/elastic/kibana/issues/247028#issuecomment-3682941117)\nis
a better description of the issue.\n\n## To Verify\n\n1. Start ES and
Kibana\n2. Generate some alerts using the `security-documents-generator`
and run\nthe risk scoring task\n3. Navigate to the Entity Analytics
Overview and open the details flyout\nfor an entity\n4. Click the
hamburger menu and see that an \"gear\" icon is available\n(although the
screenshot is old and shows an \"eye\")\n<img width=\"831\"
height=\"268\" alt=\"Screenshot 2026-01-05 at 4 44
28 PM\"\nsrc=\"https://github.com/user-attachments/assets/e7b3d1a0-e4ab-4d16-b25c-47475d705315\"\n/>\n\n5.
Click the icon and open the anonymization settings modal to
customize\nanonymization settings\n<img width=\"771\" height=\"887\"
alt=\"Screenshot 2026-01-05 at 4 46
55 PM\"\nsrc=\"https://github.com/user-attachments/assets/b8895f32-f75b-4af9-835b-0cf8a5bbecf7\"\n/>\n\n---------\n\nCo-authored-by:
Steph Milovic <stephanie.milovic@elastic.co>\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"4e40a027a46e6c6969ae9c7c69f961ae3d3f9dcf","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Entity
Analytics","backport:version","v9.3.0","v9.4.0"],"title":"[Entity
Analytics] Add ability to access anonymization modal in entity highlight
component","number":247887,"url":"https://github.com/elastic/kibana/pull/247887","mergeCommit":{"message":"[Entity
Analytics] Add ability to access anonymization modal in entity highlight
component (#247887)\n\nResolves
https://github.com/elastic/kibana/issues/247028\n\n## Summary\n\nThe
entity highlight component uses global anonymization settings that\ncan
be managed via the anonymization modal. Previously, we were
allowing\nusers to toggle anonymization on and off but were not allowing
access to\nadjust the anonymization settings from this menu. This PR
adds the\nability to open the anonymization modal settings from the
menu.\n\nNote, the original issue description mentioned that these
anonymization\nsettings should not be shown in Agent Builder mode. While
it is true\nthat Agent Builder does not handle anonymization, the entity
highlight\ndoes not directly use Agent Builder and so these
anonymization settings\nshould show up regardless of whether we're using
Agent Builder or\nClassic AI Assistant.
[This\ncomment](https://github.com/elastic/kibana/issues/247028#issuecomment-3682941117)\nis
a better description of the issue.\n\n## To Verify\n\n1. Start ES and
Kibana\n2. Generate some alerts using the `security-documents-generator`
and run\nthe risk scoring task\n3. Navigate to the Entity Analytics
Overview and open the details flyout\nfor an entity\n4. Click the
hamburger menu and see that an \"gear\" icon is available\n(although the
screenshot is old and shows an \"eye\")\n<img width=\"831\"
height=\"268\" alt=\"Screenshot 2026-01-05 at 4 44
28 PM\"\nsrc=\"https://github.com/user-attachments/assets/e7b3d1a0-e4ab-4d16-b25c-47475d705315\"\n/>\n\n5.
Click the icon and open the anonymization settings modal to
customize\nanonymization settings\n<img width=\"771\" height=\"887\"
alt=\"Screenshot 2026-01-05 at 4 46
55 PM\"\nsrc=\"https://github.com/user-attachments/assets/b8895f32-f75b-4af9-835b-0cf8a5bbecf7\"\n/>\n\n---------\n\nCo-authored-by:
Steph Milovic <stephanie.milovic@elastic.co>\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"4e40a027a46e6c6969ae9c7c69f961ae3d3f9dcf"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247887","number":247887,"mergeCommit":{"message":"[Entity
Analytics] Add ability to access anonymization modal in entity highlight
component (#247887)\n\nResolves
https://github.com/elastic/kibana/issues/247028\n\n## Summary\n\nThe
entity highlight component uses global anonymization settings that\ncan
be managed via the anonymization modal. Previously, we were
allowing\nusers to toggle anonymization on and off but were not allowing
access to\nadjust the anonymization settings from this menu. This PR
adds the\nability to open the anonymization modal settings from the
menu.\n\nNote, the original issue description mentioned that these
anonymization\nsettings should not be shown in Agent Builder mode. While
it is true\nthat Agent Builder does not handle anonymization, the entity
highlight\ndoes not directly use Agent Builder and so these
anonymization settings\nshould show up regardless of whether we're using
Agent Builder or\nClassic AI Assistant.
[This\ncomment](https://github.com/elastic/kibana/issues/247028#issuecomment-3682941117)\nis
a better description of the issue.\n\n## To Verify\n\n1. Start ES and
Kibana\n2. Generate some alerts using the `security-documents-generator`
and run\nthe risk scoring task\n3. Navigate to the Entity Analytics
Overview and open the details flyout\nfor an entity\n4. Click the
hamburger menu and see that an \"gear\" icon is available\n(although the
screenshot is old and shows an \"eye\")\n<img width=\"831\"
height=\"268\" alt=\"Screenshot 2026-01-05 at 4 44
28 PM\"\nsrc=\"https://github.com/user-attachments/assets/e7b3d1a0-e4ab-4d16-b25c-47475d705315\"\n/>\n\n5.
Click the icon and open the anonymization settings modal to
customize\nanonymization settings\n<img width=\"771\" height=\"887\"
alt=\"Screenshot 2026-01-05 at 4 46
55 PM\"\nsrc=\"https://github.com/user-attachments/assets/b8895f32-f75b-4af9-835b-0cf8a5bbecf7\"\n/>\n\n---------\n\nCo-authored-by:
Steph Milovic <stephanie.milovic@elastic.co>\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"4e40a027a46e6c6969ae9c7c69f961ae3d3f9dcf"}}]}]
BACKPORT-->

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
devamanv pushed a commit to devamanv/kibana that referenced this pull request Jan 12, 2026
…y highlight component (elastic#247887)

Resolves elastic#247028

## Summary

The entity highlight component uses global anonymization settings that
can be managed via the anonymization modal. Previously, we were allowing
users to toggle anonymization on and off but were not allowing access to
adjust the anonymization settings from this menu. This PR adds the
ability to open the anonymization modal settings from the menu.

Note, the original issue description mentioned that these anonymization
settings should not be shown in Agent Builder mode. While it is true
that Agent Builder does not handle anonymization, the entity highlight
does not directly use Agent Builder and so these anonymization settings
should show up regardless of whether we're using Agent Builder or
Classic AI Assistant. [This
comment](elastic#247028 (comment))
is a better description of the issue.

## To Verify

1. Start ES and Kibana
2. Generate some alerts using the `security-documents-generator` and run
the risk scoring task
3. Navigate to the Entity Analytics Overview and open the details flyout
for an entity
4. Click the hamburger menu and see that an "gear" icon is available
(although the screenshot is old and shows an "eye")
<img width="831" height="268" alt="Screenshot 2026-01-05 at 4 44 28 PM"
src="https://github.com/user-attachments/assets/e7b3d1a0-e4ab-4d16-b25c-47475d705315"
/>

5. Click the icon and open the anonymization settings modal to customize
anonymization settings
<img width="771" height="887" alt="Screenshot 2026-01-05 at 4 46 55 PM"
src="https://github.com/user-attachments/assets/b8895f32-f75b-4af9-835b-0cf8a5bbecf7"
/>

---------

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team v9.3.0 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security Solution] [Bug] The option for 'Show anonymized' is being shown with Agent builder under entities flyout

5 participants