-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type #248132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
js-jankisalvi
merged 2 commits into
elastic:main
from
js-jankisalvi:fix-mw-internal-client
Jan 8, 2026
Merged
[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type #248132
js-jankisalvi
merged 2 commits into
elastic:main
from
js-jankisalvi:fix-mw-internal-client
Jan 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
approved these changes
Jan 7, 2026
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
cnasikas
approved these changes
Jan 8, 2026
Contributor
|
Starting backport for target branches: 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2026
…idden SO type (elastic#248132) ## Summary Internal MW client using internal repository was introduced in elastic#247390. It created problems while fetching MWs using all spaces in synthetics plugin. This PR fixes the issue. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 345ec13)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2026
…sing hidden SO type (#248132) (#248219) # Backport This will backport the following commits from `main` to `9.3`: - [[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type (#248132)](#248132) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Janki Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2026-01-08T09:07:03Z","message":"[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type (#248132)\n\n## Summary\n\nInternal MW client using internal repository was introduced in\nhttps://github.com//pull/247390.\nIt created problems while fetching MWs using all spaces in synthetics\nplugin.\n\nThis PR fixes the issue.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"345ec13b123cf9b880b5e2a71e8630aa464bd403","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","backport:version","Feature:Maintenance Window","v9.3.0","v9.4.0"],"title":"[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type","number":248132,"url":"https://github.com/elastic/kibana/pull/248132","mergeCommit":{"message":"[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type (#248132)\n\n## Summary\n\nInternal MW client using internal repository was introduced in\nhttps://github.com//pull/247390.\nIt created problems while fetching MWs using all spaces in synthetics\nplugin.\n\nThis PR fixes the issue.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"345ec13b123cf9b880b5e2a71e8630aa464bd403"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248132","number":248132,"mergeCommit":{"message":"[ResponseOps][MaintenanceWindows] Fix mw internal client by passing hidden SO type (#248132)\n\n## Summary\n\nInternal MW client using internal repository was introduced in\nhttps://github.com//pull/247390.\nIt created problems while fetching MWs using all spaces in synthetics\nplugin.\n\nThis PR fixes the issue.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"345ec13b123cf9b880b5e2a71e8630aa464bd403"}}]}] BACKPORT--> Co-authored-by: Janki Salvi <[email protected]>
devamanv
pushed a commit
to devamanv/kibana
that referenced
this pull request
Jan 12, 2026
…idden SO type (elastic#248132) ## Summary Internal MW client using internal repository was introduced in elastic#247390. It created problems while fetching MWs using all spaces in synthetics plugin. This PR fixes the issue. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
bug
Fixes for quality problems that affect the customer experience
Feature:Maintenance Window
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Platform ResponseOps team (formerly the Cases and Alerting teams) t//
v9.3.0
v9.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internal MW client using internal repository was introduced in #247390.
It created problems while fetching MWs using all spaces in synthetics plugin.
This PR fixes the issue.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
backport:*labels.