Skip to content

reverts explicit cps configurations#254817

Open
bdo-elastic wants to merge 1 commit intoelastic:mainfrom
bdo-elastic:bdo-remove-explicit-cps-config
Open

reverts explicit cps configurations#254817
bdo-elastic wants to merge 1 commit intoelastic:mainfrom
bdo-elastic:bdo-remove-explicit-cps-config

Conversation

@bdo-elastic
Copy link
Member

https://github.com/elastic/kibana-team/issues/2885

Summary

as stated in https://github.com/elastic/kibana-team/issues/2885#issuecomment-3926987437, control plane is in control of the cpsEnabled flag, and thus we need to remove our explicit configuration of that flag to remove interference with control plane's settings.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

this pr does not introduce any risks.

@bdo-elastic bdo-elastic requested review from a team as code owners February 24, 2026 21:38
@bdo-elastic bdo-elastic added the release_note:skip Skip the PR/issue when compiling release notes label Feb 24, 2026
@bdo-elastic bdo-elastic requested review from a team as code owners February 24, 2026 21:38
@bdo-elastic bdo-elastic added the backport:skip This PR does not require backporting label Feb 24, 2026
@bdo-elastic bdo-elastic requested a review from a team as a code owner February 24, 2026 21:38
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / discover responsive sidebar search bar customization should not render CustomDataViewPicker

Metrics [docs]

✅ unchanged

@azasypkin
Copy link
Contributor

as stated in https://github.com/elastic/kibana-team/issues/2885#issuecomment-3926987437, control plane is in control of the cpsEnabled flag, and thus we need to remove our explicit configuration of that flag to remove interference with control plane's settings.

I'm curious how that would work for our local development and CI for the specific tiers. What would the sync behavior be from the controller to our local dev and CI setup? For instance, if I run Kibana in a Security Essentials tier where CPS is disabled, how can I validate that nothing is broken and working as intended (e.g, some code doesn't account for unavailable CPS)? Are developers expected to know the CPS status for specific tiers and set this manually, or is there a more robust way to handle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants