You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
I'm curious how that would work for our local development and CI for the specific tiers. What would the sync behavior be from the controller to our local dev and CI setup? For instance, if I run Kibana in a Security Essentials tier where CPS is disabled, how can I validate that nothing is broken and working as intended (e.g, some code doesn't account for unavailable CPS)? Are developers expected to know the CPS status for specific tiers and set this manually, or is there a more robust way to handle this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/elastic/kibana-team/issues/2885
Summary
as stated in https://github.com/elastic/kibana-team/issues/2885#issuecomment-3926987437, control plane is in control of the cpsEnabled flag, and thus we need to remove our explicit configuration of that flag to remove interference with control plane's settings.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
this pr does not introduce any risks.