[Security Solution][Detection Engine] EQL rule document merging: treat dot and nested notation the same#254830
Open
dhurley14 wants to merge 12 commits intoelastic:mainfrom
Open
[Security Solution][Detection Engine] EQL rule document merging: treat dot and nested notation the same#254830dhurley14 wants to merge 12 commits intoelastic:mainfrom
dhurley14 wants to merge 12 commits intoelastic:mainfrom
Conversation
dhurley14
added
review
release_note:fix
Feature:Event Correlation (EQL) Rule
…tation, updates implementations to reduce code repetition
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]
History
cc @dhurley14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163756
EQL sequence rules merge shared field-value pairs from all events into the "shell" alert. Previously, if a field appeared in dot notation (e.g.
'user.email') in some events and nested notation (e.g.user: { email }) in others, the merge logic did not treat them as the same path, so the field was omitted from the shell alert. Now, this situation will result in the nested notation field being used. Like before this change, if both fields have the same notation, that notation is preserved in the alert too.