[Automatic Migrations] Add support for Qradar Sequence and toggle for its translation capability#254879
Open
logeekal wants to merge 5 commits intoelastic:mainfrom
Open
[Automatic Migrations] Add support for Qradar Sequence and toggle for its translation capability#254879logeekal wants to merge 5 commits intoelastic:mainfrom
logeekal wants to merge 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
jonwalstedt
reviewed
Feb 26, 2026
| *This is FLATTENED list of conditions from main rule and complete dependency tree. | ||
| - Test Condition [test_id] [group_id] ( Human-readable description of the test condition 1 ) | ||
| - Test Condition [test_id] [group_id] ( Human-readable description of the test condition 2 ) | ||
| #### Key Commands ( including the negate attribute handling): |
Contributor
There was a problem hiding this comment.
Suggested change
| #### Key Commands ( including the negate attribute handling): | |
| #### Key Commands (including the negate attribute handling): |
Contributor
|
@logeekal It looks like the links to the xmls for the Qradar rule migrations (the one without pre-built rule match and with pre-built rule match) are the same file, both links point to the same file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ability for Rule Migration graph to understand
Sequence,DoubleSequenceandCauseAndEffectfunction.Below we can see the natural language description and ESQL translation summary of the Temporal Correlation sequences. As can be clearly seen and after communicating with ESQL Team, we can confirm that Sequences are not supported by ESQL. Because of this, we have also added a toggle function to add/remove support for QRadar function.
Natural description of the Sequence
ESQL Translation
Currently, ESQL responds appropriately that it cannot do Sequence Correlations. This is the expected output.
Comment without Sequence Support
Since we know that Sequences are not supported by ESQL and as it was confirmed with ESQL Team as well, we have add Sequence to
unsupportedlist of functions so that we do not waste Tokens doing the translation. When we have the capability, we can simply enable it.More Improvements
Better ESQL Query Translation Summary
Non Translatedciting the reasons.Screenshot
Inclusion Integrations indices field mapping
As can be seen in below screenshot, field mappings are now included in the translation node which results in better query. Screenshot of this trace is included below:
Screenshot
This inevitably results in better query. See before/after screenshots below:
Desk Testing Plan
Testing the New Feature
Sequence Rule Migrations
without pre-built rule matchNot Translatedand explanation in theSummarysection as to why.Sequence Rule Migrations
with pre-built rule matchNot Translatedand explanation as to why as shown above.Regression Testing
NetfloworNetwork packet captureorOraclewith corresponding indices and correct columns.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.