[APM] Add kibana.alert.grouping to error count threshold alerts#254894
Open
fkanout wants to merge 4 commits intoelastic:mainfrom
Open
[APM] Add kibana.alert.grouping to error count threshold alerts#254894fkanout wants to merge 4 commits intoelastic:mainfrom
fkanout wants to merge 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @fkanout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #224901
Implements
kibana.alert.groupingfor the APM Error count threshold rule (apm.error_rate) as part of the Observability grouping initiative.What changed
kibana.alert.groupingto active alert payloads in the error count executor.kibana.alert.groupingfrom the recovered alert document, with a backward-compatible fallback to reconstructed grouping for older alerts.kibana.alert.grouping.*(string fields askeyword) in APM rule alert mappings.Why
This makes grouping first-class in alert documents for filtering/search/autocomplete and aligns recovered
context.groupingbehavior with the expected source of truth (kibana.alert.grouping).Test plan
yarn test:jest x-pack/solutions/observability/plugins/apm/server/routes/alerts/rule_types/error_count/register_error_count_rule_type.test.tsyarn test:ftr --config x-pack/solutions/observability/test/api_integration_deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts --grep "error count threshold alert"Validation results
Notes
kibana.alert.grouping.*.