Skip to content

[Alerting v2] Remove condition field#260926

Open
benakansara wants to merge 3 commits intoelastic:mainfrom
benakansara:chore/remove-condition-field
Open

[Alerting v2] Remove condition field#260926
benakansara wants to merge 3 commits intoelastic:mainfrom
benakansara:chore/remove-condition-field

Conversation

@benakansara
Copy link
Copy Markdown
Contributor

@benakansara benakansara commented Apr 2, 2026

Resolves https://github.com/elastic/rna-program/issues/274

Summary

  • Removes the "Trigger condition" (WHERE clause) field from the evaluation section of the rule create/edit form
  • Removes the recovery condition field
  • Removes alert condition block from rule details page
  • Updates preview hook to use only evaluation.query.base / recoveryPolicy.query.base, ignoring the condition field
  • Removes condition from API payloads on write and ignores it from API responses on read, guarding against stale values from API-created rules

Edit rule - evaluation

Screenshot 2026-04-02 at 3 24 12 PM

Edit rule - recovery

Screenshot 2026-04-02 at 3 24 28 PM

Rule details page

Screenshot 2026-04-02 at 4 26 54 PM

@benakansara benakansara self-assigned this Apr 2, 2026
@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 2, 2026
@github-actions github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Apr 2, 2026
@benakansara benakansara changed the title remove condition field [Alerting V2] Remove condition field Apr 2, 2026
@benakansara benakansara force-pushed the chore/remove-condition-field branch 2 times, most recently from 8fd7f32 to 4768684 Compare April 2, 2026 14:18
@benakansara benakansara force-pushed the chore/remove-condition-field branch from 4768684 to 91e6d55 Compare April 2, 2026 14:19
@benakansara benakansara marked this pull request as ready for review April 2, 2026 14:28
@benakansara benakansara requested a review from a team as a code owner April 2, 2026 14:28
@benakansara benakansara changed the title [Alerting V2] Remove condition field [Alerting v2] Remove condition field Apr 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 2, 2026

Approvability

Verdict: Needs human review

This PR removes the condition field feature from the Alerting v2 rule form, fundamentally changing how evaluation and recovery queries are processed. While the author owns all changed files, removing feature functionality represents a significant runtime behavior change that warrants human review to confirm the removal aligns with product intent.

You can customize Macroscope's approvability policy. Learn more.

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #211 / serverless search UI Rule details Edit rule with deleted connector should show and update deleted connectors when there are existing connectors of the same type

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alertingVTwo 445 440 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alertingVTwo 280.7KB 269.2KB -11.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alertingVTwo 148.1KB 147.7KB -385.0B

History

cc @benakansara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:actionable-obs PRs authored by the actionable obs team backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants