[Alerting v2] Remove condition field#260926
Open
benakansara wants to merge 3 commits intoelastic:mainfrom
Open
[Alerting v2] Remove condition field#260926benakansara wants to merge 3 commits intoelastic:mainfrom
benakansara wants to merge 3 commits intoelastic:mainfrom
Conversation
x-pack/platform/plugins/shared/alerting_v2/public/components/rule_details/recovery_policy.tsx
Show resolved
Hide resolved
8fd7f32 to
4768684
Compare
4768684 to
91e6d55
Compare
Contributor
ApprovabilityVerdict: Needs human review This PR removes the condition field feature from the Alerting v2 rule form, fundamentally changing how evaluation and recovery queries are processed. While the author owns all changed files, removing feature functionality represents a significant runtime behavior change that warrants human review to confirm the removal aligns with product intent. You can customize Macroscope's approvability policy. Learn more. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @benakansara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/elastic/rna-program/issues/274
Summary
evaluation.query.base/recoveryPolicy.query.base, ignoring theconditionfieldconditionfrom API payloads on write and ignores it from API responses on read, guarding against stale values from API-created rulesEdit rule - evaluation
Edit rule - recovery
Rule details page