-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[FeatureBranch/DoNotReview][Chrome Next] Keep all AI buttons #260937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dosant
merged 2 commits into
elastic:feature/chrome-next
from
Dosant:feature/chrome-next-ai-button
Apr 2, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/core/packages/chrome/browser/src/chrome_next/ai_button.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| import type { ChromeExtensionContent } from '@kbn/core-mount-utils-browser'; | ||
|
|
||
| /** @public */ | ||
| export interface ChromeNextAiButton { | ||
| content: ChromeExtensionContent; | ||
| } |
47 changes: 47 additions & 0 deletions
47
src/core/packages/chrome/browser/src/chrome_next/chrome_next.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| import type { ChromeNextAiButton } from './ai_button'; | ||
| import type { ChromeNextGlobalSearchConfig } from './global_search'; | ||
| import type { ChromeNextHeaderConfig } from './header'; | ||
|
|
||
| /** | ||
| * Chrome-Next APIs: header configuration, AI button slot, global search, and future slots. | ||
| * @public | ||
| */ | ||
| export interface ChromeNext { | ||
| header: { | ||
| /** | ||
| * Set the Chrome-Next header configuration for the current page. | ||
| * Chrome renders the title, metadata, global actions, and app menu. | ||
| * | ||
| * Pass `undefined` to clear (e.g. on unmount or route change). | ||
| * Automatically cleared on app change. | ||
| */ | ||
| set(config?: ChromeNextHeaderConfig): void; | ||
| }; | ||
| aiButton: { | ||
| /** | ||
| * Register an AI button for the Chrome-Next header. | ||
| * Multiple plugins can register buttons; each owns its own visibility logic. | ||
| * Chrome renders all registered buttons sorted by `order` in a fixed slot | ||
| * at the far right of the header. | ||
| * Returns an unregister callback. Global — persists across app changes. | ||
| */ | ||
| register(button: ChromeNextAiButton): () => void; | ||
| }; | ||
| globalSearch: { | ||
| /** | ||
| * Set the global search configuration for the Chrome-Next sidenav. | ||
| * Chrome renders a search icon button in the sidenav header items; clicking it fires `onClick`. | ||
| * Pass `undefined` to remove the button. Global — persists across app changes. | ||
| */ | ||
| set(config?: ChromeNextGlobalSearchConfig): void; | ||
| }; | ||
| } |
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| export type { ChromeNextAiButton } from './ai_button'; | ||
| export type { ChromeNext } from './chrome_next'; | ||
| export type { ChromeNextGlobalSearchConfig } from './global_search'; | ||
| export type { | ||
| ChromeNextHeaderBack, | ||
| ChromeNextHeaderBadge, | ||
| ChromeNextHeaderCallout, | ||
| ChromeNextHeaderConfig, | ||
| ChromeNextHeaderGlobalActions, | ||
| ChromeNextHeaderMetadataSlotItem, | ||
| ChromeNextHeaderTab, | ||
| } from './header'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about
@inheritdoc. I've been copy pasting docs everywhere