Security Solution] Fix string spread bug when syncing watchlists to Entity Store #260941
Merged
CAWilson94 merged 2 commits intoelastic:mainfrom Apr 2, 2026
Merged
Security Solution] Fix string spread bug when syncing watchlists to Entity Store #260941CAWilson94 merged 2 commits intoelastic:mainfrom
CAWilson94 merged 2 commits intoelastic:mainfrom
Conversation
…ntity store Fixes a bug where single-string values in the Entity Store were being incorrectly parsed and spread into an array of individual characters during sync. If the Entity Store contained a single string value instead of an array (e.g., ), the sync logic would destructure it via , resulting in an array of characters . This commit adds defensive checks in both (when reading from Elasticsearch) and (before mutating) to ensure is always safely coerced into an array of strings before any spread operations occur.
CAWilson94
added
backport:skip
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
CAWilson94
added
the
release_note:skip
tiansivive
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix string spread bug when syncing watchlists to entity store
Fixes a bug where single-string
entity.attributes.watchlistsvaluesin the Entity Store were being incorrectly parsed and spread into an
array of individual characters during sync.
If the Entity Store contained a single string value instead of an array
(e.g.,
"privileged-user-monitoring-watchlist-id"), the sync logicwould destructure it via
[...watchlists, watchlistId], resulting inan array of characters
["p", "r", "i", "v", ...].This commit adds defensive checks in both
WatchlistEntitiesService(when reading from Elasticsearch) and
entity_store_sync(before mutating)to ensure
currentWatchlistsis always safely coerced into an array ofstrings before any spread operations occur.