[Discover sessions as Code] Default-on discover.embeddableTransforms#260945
Open
lukasolson wants to merge 1 commit intoelastic:mainfrom
Open
[Discover sessions as Code] Default-on discover.embeddableTransforms#260945lukasolson wants to merge 1 commit intoelastic:mainfrom
lukasolson wants to merge 1 commit intoelastic:mainfrom
Conversation
Introduce EMBEDDABLE_TRANSFORMS_FEATURE_FLAG_DEFAULT and use it for: - server plugin initial state and getBooleanValue$ fallback - client getBooleanValue fallback in discoverFeatureFlags - discover services test mock Fresh installs and unset flags now use the declarative Discover session panel shape by default; explicit false keeps the legacy path. Refs elastic#260103 Made-with: Cursor
lukasolson
added
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #260103.
When the
discover.embeddableTransformsfeature flag is unset, Kibana now defaults to enabled (declarative Discover session panel shape / dashboards-as-code alignment). Setting the flag explicitly tofalsecontinues to use the legacytransformOutpath.Changes
EMBEDDABLE_TRANSFORMS_FEATURE_FLAG_DEFAULTindiscover/common/constants.tsas the single source of truth (true).embeddableTransformsEnabledmatches the default;getBooleanValue$already used this field as fallback.getEmbeddableTransformsEnabled()uses the same default forgetBooleanValuewhen the flag is unset.createDiscoverServicesMockreturnstruefor embeddable transforms to mirror production default; tests that need legacy behavior still override the mock.Acceptance criteria
falsestill disables new path (legacy unchanged).legacyTransformOutor flag key.Closes #260103
Made with Cursor