[RnA: Alerting-V2] Rule list: improve Tags truncation #260951
[RnA: Alerting-V2] Rule list: improve Tags truncation #260951yiannisnikolopoulos merged 5 commits intoelastic:mainfrom
Conversation
…e width of other columns too, added check for max_visible_labels
…wed it to the user, so the tags_field.tsx was updated with the changes to show the validation error if the tag's character length is more than 64 characters
ApprovabilityVerdict: Needs human review The PR adds tag length validation (max 64 chars) and improves tag display truncation in the rules list. While the changes are straightforward, the author does not own any of the modified files—all are owned by @elastic/rna-project-team—so designated owners should review. You can customize Macroscope's approvability policy. Learn more. |
yiannisnikolopoulos
left a comment
There was a problem hiding this comment.
QQ: Why did we choose to follow this approach for truncation? It seems that the EuiBadge already supports truncation and default browser tooltips. Quoting from EUI docs: To ensure proper wrapping, truncation and spacing of multiple badges, it is advisable to wrap them in a EuiBadgeGroup.
Also a few nits:
- Even a short tag like "prod" gets a tooltip repeating the same text. Consider only showing the tooltip when the text is actually truncated(if we decide to keep the current approach)
- Consider exporting the constant
MAX_TAG_LENGTHfrom@kbn/alerting-v2-schemasand importing it in both client and server side. data-test-subjonEuiToolTipis silently dropped and never appears in the DOM. It can be removed or moved to a wrapper around the tooltip
|
@yiannisnikolopoulos thanks!
Two others are fully valid, on it. |
|
@ana-davydova thanks for addressing the comments. Just one small issue that I noticed, besides the following it LGTM: |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|

Closes #257
Improves tag display in the alerting v2 rules list table and adds tag length validation to the rule creation form.
Changes
Rules list: tag truncation
Rule form: tag length validation
Test plan