Skip to content

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Jan 11, 2018

this is a demo of the generated docs for versions of all plugins that have a docs/index.asciidoc

| <<{version}-plugins-{type}s-{plugin}-pipeline>> |{logstash-ref}/configuration-file-structure.html#string[string]|No
| <<{version}-plugins-{type}s-{plugin}-pool_max>> |{logstash-ref}/configuration-file-structure.html#number[number]|No
| <<{version}-plugins-{type}s-{plugin}-pool_max_per_route>> |{logstash-ref}/configuration-file-structure.html#number[number]|No
| <<{version}-plugins-{type}s-{plugin}-proxy>> |{logstash-ref}/configuration-file-structure.html#uri[uri]|No
Copy link
Contributor

@dedemorton dedemorton Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the uri type.

@dedemorton
Copy link
Contributor

@jsvd We should talk about how we are going to iterate over these files. I want to avoid having to manually fix stuff over and over again. Once we get a set of files building without errors, can we say that they are done and iterate over a different set of files for the next round of fixes?

Is that possible? I'd like to say that those versions of the plugin docs are done. After we've gone through all the plugins and tweaked the script, I'll make any changes required to the plugin repos (mostly for external links, I suspect), and then we'll only run into errors when someone checks in asciidoc that breaks something. If we're only building the new versions, then we should never have to generate the older ones again, right? WDYT? IT might be worth meeting to discuss this.

@jsvd
Copy link
Member Author

jsvd commented Jan 19, 2018

closing as we're moving to other rounds of plugin generation

@jsvd jsvd closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants