Removes the fixed version number and uses plugin version instead in the unit tests. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashhurs
changed the title
💚 Build Succeeded
|
donoghuc
approved these changes
Jan 28, 2025
Yeah, initially to make other unit tests happy hard coded and focused the version mismatch section. Then forgot to change :) Thanks for quick review. |
mashhurs
deleted the
fix-unit-tests-after-version-compatibility-change
branch
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit c9f0a73)
|
@logstashmachine backport 8.16 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit c9f0a73)
|
@logstashmachine backport 8.17 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit c9f0a73)
mashhurs
added a commit
that referenced
this pull request
Jan 28, 2025
…) (#256) (cherry picked from commit c9f0a73) Co-authored-by: Mashhur <[email protected]>
mashhurs
added a commit
that referenced
this pull request
Jan 28, 2025
…) (#257) (cherry picked from commit c9f0a73) Co-authored-by: Mashhur <[email protected]>
mashhurs
added a commit
that referenced
this pull request
Jan 28, 2025
…) (#258) (cherry picked from commit c9f0a73) Co-authored-by: Mashhur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes hard coded version in the unit tests and replaces with the plugin version.
Forgot 🤦 removing it in #247