Skip to content

Removes the fixed version number and uses plugin version instead in the unit tests. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Removes the fixed version number and uses plugin version instead in the unit tests. #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions spec/unit/elastic_integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@
let(:registered_plugin) { plugin.tap(&:register) }
after(:each) { plugin.close }

let(:connected_es_version_info) { {'number' => '8.17.0', 'build_flavor' => 'default'} }
let(:version) { LogStash::Filters::ElasticIntegration::VERSION }

# assuming that the plugin is connected to the ES with the same version
# see the "plugin vs connected ES versions compatibility" unit test when versions differ
let(:connected_es_version_info) { {'number' => version, 'build_flavor' => 'default'} }

shared_examples "validate `ssl_enabled`" do
it "enables SSL" do
Expand Down Expand Up @@ -733,7 +737,6 @@

describe "plugin vs connected ES versions compatibility" do
let(:config) { super().merge("hosts" => %w[127.0.0.2:9300]) }
let(:version) { LogStash::Filters::ElasticIntegration::VERSION }
let(:plugin_major_version) { version.split('.').first.to_i }
let(:plugin_minor_version) { version.split('.')[1].to_i }
let(:base_message) { "This #{version} version of plugin embedded Ingest node components from Elasticsearch #{plugin_major_version}.#{plugin_minor_version}" }
Expand Down