Skip to content

Generate noop CI step if next (is only available during the FF) is N.A #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Generate noop CI step if next (is only available during the FF) is N.A #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5a2ef
Generate noop CI step if next (is only available during the FF) is no…
mashhurs Dec 13, 2024
332307f
Apply suggestions from code review
mashhurs Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/build-pipeline/generate-steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def generate_steps_for_scheduler(versions) -> list:
steps: list = []
snapshots = versions["snapshots"]
for snapshot_version in snapshots:
if snapshots[snapshot_version].startswith("7."):
if snapshots[snapshot_version] is None or snapshots[snapshot_version].startswith("7."):
continue
full_stack_version = snapshots[snapshot_version]
version_parts = snapshots[snapshot_version].split(".")
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/e2e-pipeline/generate-steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def generate_steps_for_scheduler(versions) -> list:
steps: list = []
snapshots = versions["snapshots"]
for snapshot_version in snapshots:
if snapshots[snapshot_version].startswith("7."):
if snapshots[snapshot_version] is None or snapshots[snapshot_version].startswith("7."):
continue
full_stack_version = snapshots[snapshot_version]
version_parts = snapshots[snapshot_version].split(".")
Expand Down