Skip to content

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 23, 2025

What does this PR do?

Why is it important/What is the impact to the user?

Use the same backport mechanism as done in some other projects. While still support for the former approach.

Tasks

  • Wait for Mergify to be installed
  • Create GitHub labels

Follow-ups

Related issues

Relates elastic/logstash#16933

@v1v v1v marked this pull request as draft January 23, 2025 17:57
branches:
- main
- 8.*
- 9.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leverage the branches defined in the repo for CI purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leverage the branches defined in the repo for CI purpose?

In GitHub actions, the branches section accept static values or wildcards , if you mean being explicit, we can, or if you mean to add 7.17, I can include it. However, I cannot think of any issues for running the pre-commit workflow with any push commit in any of those wildcard branches. Or do you have any other concerns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, if you want to avoid maintaining branches.json, we have a public bucket to help with those details too, see https://storage.googleapis.com/artifacts-api/snapshots/branches.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is maintenance:

  • do we need to update pre-defined valid .mergify.yml on major & minor releases?.
  • if so how other teams are modifying to avoid manual effort?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update pre-defined valid .mergify.yml on major & minor releases?.
if so how other teams are modifying to avoid manual effort?

I understand, and thanks for pointing those concerns! This PR is still draft and gathering those questions can help us to have something workable and fully functional.

We have automated that as part of the FF scripts teams use. For instance:

  1. APM Server uses this process
  2. Beats uses an internal process to do the same.

In those cases, there are PRs with those changes created automatically. See elastic/apm-server#11760 or elastic/beats#41706

That's something we can help with, for instance, I added the support for creating the backport labels for the logstash in elastic/logstash@f2ccbce (#16937). I'll add the support to modify the mergify file in logstash and will review how those bumps work for this project to do the same

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for sharing valuable info.
For this case, we need to also include a manual (in the Logstash release) and mention both logstash and elastic_integration repos.

use what it has been enabled in logstash
@v1v v1v marked this pull request as ready for review March 12, 2025 09:42
mashhurs
mashhurs previously approved these changes Mar 12, 2025
Copy link
Collaborator

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment to remove 7.17.

Co-authored-by: Mashhur <[email protected]>
Copy link
Collaborator

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashhurs mashhurs merged commit 6e9b35a into elastic:main Mar 17, 2025
4 of 5 checks passed
Copy link

mergify bot commented Mar 17, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants