-
Notifications
You must be signed in to change notification settings - Fork 13
mergify: support backports automation with labels #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
branches: | ||
- main | ||
- 8.* | ||
- 9.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leverage the branches defined in the repo for CI purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leverage the branches defined in the repo for CI purpose?
In GitHub actions, the branches
section accept static values or wildcards , if you mean being explicit, we can, or if you mean to add 7.17
, I can include it. However, I cannot think of any issues for running the pre-commit
workflow with any push commit in any of those wildcard branches. Or do you have any other concerns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, if you want to avoid maintaining branches.json, we have a public bucket to help with those details too, see https://storage.googleapis.com/artifacts-api/snapshots/branches.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is maintenance:
- do we need to update pre-defined valid
.mergify.yml
on major & minor releases?. - if so how other teams are modifying to avoid manual effort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update pre-defined valid .mergify.yml on major & minor releases?.
if so how other teams are modifying to avoid manual effort?
I understand, and thanks for pointing those concerns! This PR is still draft and gathering those questions can help us to have something workable and fully functional.
We have automated that as part of the FF scripts teams use. For instance:
- APM Server uses this process
- Beats uses an internal process to do the same.
In those cases, there are PRs with those changes created automatically. See elastic/apm-server#11760 or elastic/beats#41706
That's something we can help with, for instance, I added the support for creating the backport labels for the logstash in elastic/logstash@f2ccbce
(#16937). I'll add the support to modify the mergify
file in logstash and will review how those bumps work for this project to do the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for sharing valuable info.
For this case, we need to also include a manual (in the Logstash release) and mention both logstash and elastic_integration repos.
use what it has been enabled in logstash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comment to remove 7.17.
Co-authored-by: Mashhur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
What does this PR do?
Mergify
does not support this feature out of the box, see github-actions: support for copying the backport labels apm-server#15190Why is it important/What is the impact to the user?
Use the same backport mechanism as done in some other projects. While still support for the former approach.
Tasks
Follow-ups
Related issues
Relates elastic/logstash#16933