Skip to content

Conversation

mashhurs
Copy link
Collaborator

@mashhurs mashhurs commented Mar 12, 2025

Description

Recent upstream ES GeoIP.Factory#create interface change broke the plugin.
This PR applies those changes to bring the build state back to green.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe my question is naive, but shouldn't we update also

public SetSecurityUserProcessor create(Map<String, Processor.Factory> registry, String processorTag,
String description, Map<String, Object> config) {
to include this new ProjectId param?

@mashhurs
Copy link
Collaborator Author

Maybe my question is naive, but shouldn't we update also

public SetSecurityUserProcessor create(Map<String, Processor.Factory> registry, String processorTag,
String description, Map<String, Object> config) {

to include this new ProjectId param?

Interesting... you don't see it in the difference?

Screenshot 2025-03-13 at 11 13 21 AM

@mashhurs mashhurs requested a review from andsel March 13, 2025 18:14
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs mashhurs merged commit b633139 into elastic:main Mar 14, 2025
3 checks passed
@mashhurs mashhurs deleted the apply-es-geoip-factory-interface-change branch March 14, 2025 16:33
@mashhurs mashhurs mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants