-
Notifications
You must be signed in to change notification settings - Fork 13
Sync up with Elasticsearch main on GeoIP changes. #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync up with Elasticsearch main on GeoIP changes. #309
Conversation
…r#isValid and IpDatabaseProvider#getDatabase methods have now projectId additional params.
This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
|
💔 Build Failed
Failed CI StepsHistory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your assessment. Looks like the method signatures just need to be updated and we dont need to do anything with the projectId
s that are now available.
As noted, test failures are just due to snapshot builds not being available yet.
LGTM.
@Mergifyio backport 9.1 |
✅ Backports have been created
|
…r#isValid and IpDatabaseProvider#getDatabase methods have now projectId additional params. (#309) (#310) (cherry picked from commit a005e94) Co-authored-by: Mashhur <[email protected]>
Description
GeoIp interface changes:
IpDatabaseProvider#isValid
andIpDatabaseProvider#getDatabase
methods have nowprojectId
additional params.See the upstream change for the details and I am not seeing to apply project ID logic in Logstash side as it was introduced to separate project path in the MP nodes.
Note that 9.0.4 CI failure is expected as snapshot isn't available yet.
Test