Skip to content

Whitelist terminate processor in E2E tests. #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Whitelist terminate processor in E2E tests. #327

merged 1 commit into from
Jul 7, 2025

Conversation

mashhurs
Copy link
Collaborator

@mashhurs mashhurs commented Jul 2, 2025

No functional change.

@mergify Mergify
Copy link

mergify bot commented Jul 2, 2025

This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@mashhurs mashhurs added the backport-active-all Automated backport with mergify to all the active branches label Jul 2, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mashhurs mashhurs added backport-skip Skip automated backport with mergify backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches and removed backport-active-all Automated backport with mergify to all the active branches labels Jul 7, 2025
@donoghuc
Copy link
Member

donoghuc commented Jul 7, 2025

Looks like this was added quite a while ago, elastic/elasticsearch#114157 why did it just start failing now?

@mashhurs
Copy link
Collaborator Author

mashhurs commented Jul 7, 2025

Looks like this was added quite a while ago, elastic/elasticsearch#114157 why did it just start failing now?

As this plugin runs integrations, the plugin's interest is integration package rather then ES processor. The E2E pipeline scans the processors in the https://github.com/elastic/integrations repo and terminate processor appeared last week in qualys_was package. The change: elastic/integrations@2b24cbb#diff-456eabda8e608fbd370901e45728aa1b57a88c4cb2e854349aa412d030e0554b

donoghuc
donoghuc approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional info! That is very helpful.

@mashhurs mashhurs merged commit a9d7625 into elastic:main Jul 7, 2025
5 checks passed
@mashhurs mashhurs deleted the whitelist-teminate-processor-in-e2e branch July 7, 2025 16:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

@Mergifyio backport 9.0 9.1

@mergify Mergify
Copy link

mergify bot commented Jul 7, 2025 •
edited
Loading

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 7, 2025
@mashhurs @mergify
Whitelist terminate processor in E2E tests. (#327)
444dc7f 
(cherry picked from commit a9d7625)
@mergify mergify bot mentioned this pull request Jul 7, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jul 7, 2025
@mashhurs @mergify
Whitelist terminate processor in E2E tests. (#327)
0a2395e 
(cherry picked from commit a9d7625)
@mergify mergify bot mentioned this pull request Jul 7, 2025
Merged
mashhurs added a commit that referenced this pull request Jul 7, 2025
@mergify @mashhurs
Whitelist terminate processor in E2E tests. (#327) (#328)
cfcf01c 
(cherry picked from commit a9d7625)

Co-authored-by: Mashhur <[email protected]>
mashhurs added a commit that referenced this pull request Jul 7, 2025
@mergify @mashhurs
Whitelist terminate processor in E2E tests. (#327) (#329)
39ea29f 
(cherry picked from commit a9d7625)

Co-authored-by: Mashhur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donoghuc donoghuc donoghuc approved these changes

Assignees

No one assigned

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-skip Skip automated backport with mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mashhurs @elasticmachine @donoghuc