-
Notifications
You must be signed in to change notification settings - Fork 13
[Move to ES Bridge] Build logstash-bridge
and include in the plugin
#330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
|
logstash-bridge
and include in the plugin
… to the plugin to make Stable API interfaces available.
061fdff
to
e1e1d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left just a comment, if there is real reason to have the mustRunAfter
please document why.
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tested with
> ./gradlew localGem
> gem unpack logstash-filter-elastic_integration-9.2.0-java.gem
> jar tf ./vendor/jar-dependencies/co/elastic/logstash-filter-elastic_integration/9.2.0/logstash-filter-elastic_integration-9.2.0.jar | grep logstashbridge
Plugin build issue is resolved, I have retried the CI jobs and they are 🟢 now. |
Description
Creates gradle task to compile logstash-bridge module and add jar file to the plugin to make Stable API interfaces available.
FYI: CI failures which runs after gradle tasks are not related to this PR. The plugin is experiencing build issue against ES
main
now.P.S: In between I changed the remote branch to
move-to-es-bridge-api
but since this doesn't harm anything, directly applying tomain
makes sense to me.