Skip to content

Conversation

mashhurs
Copy link
Collaborator

@mashhurs mashhurs commented Jul 10, 2025

Description

Creates gradle task to compile logstash-bridge module and add jar file to the plugin to make Stable API interfaces available.

FYI: CI failures which runs after gradle tasks are not related to this PR. The plugin is experiencing build issue against ES main now.

P.S: In between I changed the remote branch to move-to-es-bridge-api but since this doesn't harm anything, directly applying to main makes sense to me.

Copy link

mergify bot commented Jul 10, 2025

This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@mashhurs mashhurs added the backport-skip Skip automated backport with mergify label Jul 10, 2025
@mashhurs mashhurs changed the title Move to Elasticsearch Stable Bridge API [Move to ES Bridge] Build logstash-bridge and include in the plugin Jul 10, 2025
@mashhurs mashhurs changed the base branch from main to move-to-es-bridge-api July 10, 2025 21:22
@mashhurs mashhurs mentioned this pull request Jul 10, 2025
@mashhurs mashhurs changed the base branch from move-to-es-bridge-api to main July 10, 2025 22:51
… to the plugin to make Stable API interfaces available.
@mashhurs mashhurs force-pushed the move-to-stable-api branch from 061fdff to e1e1d94 Compare July 10, 2025 23:05
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just a comment, if there is real reason to have the mustRunAfter please document why.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 11, 2025

@mashhurs mashhurs requested a review from andsel July 11, 2025 14:18
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tested with

> ./gradlew localGem
> gem unpack logstash-filter-elastic_integration-9.2.0-java.gem
> jar tf ./vendor/jar-dependencies/co/elastic/logstash-filter-elastic_integration/9.2.0/logstash-filter-elastic_integration-9.2.0.jar  | grep logstashbridge

@mashhurs
Copy link
Collaborator Author

Plugin build issue is resolved, I have retried the CI jobs and they are 🟢 now.

@mashhurs mashhurs merged commit b69efae into elastic:main Jul 12, 2025
4 checks passed
@mashhurs mashhurs deleted the move-to-stable-api branch July 12, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Move to ES bridge -> plugin scope] Make Bridge API available in the plugin

3 participants