Remove no need 8.x versions from CIs tests. #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashhurs
changed the title
Collaborator
💚 Build Succeeded
cc @mashhurs |
donoghuc
reviewed
Nov 4, 2025
| snapshots = versions["snapshots"] | ||
| for snapshot_version in snapshots: | ||
| if snapshots[snapshot_version] is None or snapshots[snapshot_version].startswith("7."): | ||
| if snapshots[snapshot_version] is None or snapshots[snapshot_version].startswith("7.") or snapshot_version == "8.previous": |
Member
There was a problem hiding this comment.
I'm not following this case. What is this for?
Collaborator
Author
There was a problem hiding this comment.
This is for E2E pipeline and this filters out 8.previous from logstash-versions.yml snapshots entry:
# Track the ongoing SNAPSHOT for the "next" release for each stream
snapshots:
7.current: "7.17.30-SNAPSHOT"
8.previous: "8.18.9-SNAPSHOT"
8.current: "8.19.7-SNAPSHOT"
9.previous: "9.1.7-SNAPSHOT"
9.current: "9.2.1-SNAPSHOT"
main: "9.3.0-SNAPSHOT"
Member
There was a problem hiding this comment.
ah, we should probably remove it there too. This should be fine though!
donoghuc
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we no longer have 8.prev releases, this PR removes it from CIs.
Note that all CIs use version definitions from
mainbranch, no need to backport.