Skip to content

bump jruby to 9.2.12.0 #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2020
Merged

bump jruby to 9.2.12.0 #12071

merged 1 commit into from
Jul 8, 2020

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Jul 1, 2020 •
edited
Loading

Also tweak the documentation since most of the add-opens are no longer needed, except two:

@jsvd
Copy link
Member Author

jsvd commented Jul 2, 2020

jenkins test this please

@jsvd jsvd force-pushed the bump_jruby_9_2_12_0 branch 2 times, most recently from fd7ece4 to 4b49902 Compare July 3, 2020 15:32
@jsvd
Copy link
Member Author

jsvd commented Jul 3, 2020

@kares looking at the jruby 9.2.12.0 release notes:

The last remaining triggers of the “Illegal access” warnings and errors in JRuby core have been fixed. JRuby will avoid accessing Java modules and packages that have not been exported or opened. (#6195, #6287, #6298, #6299)

But we still have one in logstash startup for org.jruby.ext.openssl.SecurityHelper:

❯ bin/logstash -e ""
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/var/folders/cg/p_vcxtdj32d4ssw5cz3n43th0000gn/T/jruby-39776/jruby6561733352138861814jopenssl.jar) to field java.security.MessageDigest.provider
WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Sending Logstash logs to /Users/joaoduarte/elastic/logstash/build/logstash-8.0.0-SNAPSHOT/logs which is now configured via log4j2.properties
[2020-07-03T16:57:10,917][WARN ][logstash.config.source.multilocal] Ignoring the 'pipelines.yml' file because modules or command line options are specified
[2020-07-03T16:57:11,025][INFO ][logstash.runner          ] Starting Logstash {"logstash.version"=>"8.0.0", "jruby.version"=>"jruby 9.2.12.0 (2.5.7) 2020-07-01 db01a49ba6 OpenJDK 64-Bit Server VM 11.0.5+10 on 11.0.5+10 +indy +jit [darwin-x86_64]"}

@kares
Copy link
Contributor

kares commented Jul 3, 2020

yes, I know - there's more work on the warning front in terms of java-integration.
jruby-openssl still needs work (before release) - when it's released the warning you see won't be there ...

@jsvd jsvd force-pushed the bump_jruby_9_2_12_0 branch from 4b49902 to a6b0751 Compare July 7, 2020 14:28
@elasticsearch-bot elasticsearch-bot self-assigned this Jul 7, 2020
yaauie
yaauie reviewed Jul 7, 2020
View reviewed changes
@jsvd jsvd force-pushed the bump_jruby_9_2_12_0 branch from 523f950 to 30eac95 Compare July 7, 2020 17:04
@jsvd jsvd requested a review from yaauie July 7, 2020 17:05
kares
kares reviewed Jul 7, 2020
View reviewed changes
karenzone
karenzone reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking time to update the troubleshooting docs, too! <3
Builds cleanly and LGTM.

yaauie
yaauie approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@colinsurprenant
Copy link
Contributor

I just checked with recent JRuby and it seems that jruby-stdin-channel is not required anymore, JRuby $stdin is now interruptible. I will push a PR on the stdin input for this.

@yaauie
Copy link
Member

yaauie commented Jul 7, 2020

jenkins test this again please

@jsvd @yaauie
update jruby to 9.2.12.0
cf80f17 
Also tweak the documentation since most of the add-opens are no longer needed, except:

java.io due to colinsurprenant/jruby-stdin-channel#1
java.security due to jruby-openssl
java.nio.channels, sun.nio.ch, sun.management and java.io from jruby: https://github.com/jruby/jruby/blob/9.2.12.0/bin/.jruby.module_opts

Co-authored-by: Ry Biesemeyer <[email protected]>
@jsvd jsvd force-pushed the bump_jruby_9_2_12_0 branch from 30eac95 to cf80f17 Compare July 8, 2020 11:42
kares
kares approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot elasticsearch-bot merged commit 67eb274 into elastic:master Jul 8, 2020
@elasticsearch-bot
Copy link

João Duarte merged this to master!

Pull request was also backported into the following branches:

Branch Commits
7.x 85a572a

@jsvd jsvd deleted the bump_jruby_9_2_12_0 branch July 8, 2020 11:58
@jsvd
Copy link
Member Author

jsvd commented Jul 8, 2020

Thanks all for the feedback!

@colinsurprenant
Copy link
Contributor

FYI I pushed logstash-plugins/logstash-input-stdin#19 to remove the usage of jruby-stdin-channel and get rid of the An illegal reflective access operation has occurred under Java 11.

@colinsurprenant colinsurprenant mentioned this pull request Jul 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenzone karenzone karenzone left review comments

@yaauie yaauie yaauie approved these changes

+1 more reviewer

@kares kares kares approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsvd @kares @colinsurprenant @yaauie @elasticsearch-bot @karenzone