Add incomplete integration plugins to metadata.json as skip #16174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
cc @karenzone |
This was referenced May 21, 2024
karenzone
commented
May 31, 2024
Comment on lines
+444
to
+451
| "logstash-integration-internal": { | ||
| "default-plugins": false, | ||
| "skip-list": true | ||
| }, | ||
| "logstash-integration-zeromq": { | ||
| "default-plugins": false, | ||
| "skip-list": true | ||
| }, |
There was a problem hiding this comment.
Note to self @karenzone: Currently these two plugins are being skipped because of logic in docs tooling. I'm merging these changes to the skiplist now, even though necessary changes in docs tooling are still under consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip] to leave this PR out of release notes
Step 1: Move integration plugins
This PR moves
logstash-integration-internalandlogstash-integration-zeromqplugins to plugins-metadata.json and configure them asdefault-plugins: falseand"skip-list": trueto set us up to make the next set of changes to docs tooling.Next steps
Related: elastic/docs-tools#106