Skip to content

Fix denial of service caused by a 404 from elasticsearch to managed logstashes #18078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix denial of service caused by a 404 from elasticsearch to managed logstashes #18078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions x-pack/lib/config_management/elasticsearch_source.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ def pipeline_configs
begin
fetcher.fetch_config(es_version, pipeline_ids, client)
rescue LogStash::Outputs::ElasticSearch::HttpClient::Pool::BadResponseCodeError => e
# es-output 12.0.2 throws 404 as error, but we want to handle it as empty config
return [] if e.response_code == 404
# es-output 12.0.2 throws 404 as an error, returned cache if it exists, otherwise none
if e.response_code == 404
return @cached_pipelines || []
end
raise e
end

fetcher.get_pipeline_ids.collect do |pid|
get_pipeline(pid, fetcher)
end.compact
@cached_pipelines = fetcher.get_pipeline_ids.collect { |pid| get_pipeline(pid, fetcher) }.compact
return @cached_pipelines
end

def get_es_version
Expand Down