Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label. Could you fix it @ninalee12? 🙏
|
v1v
left a comment
There was a problem hiding this comment.
As I mentioned in some other PRs, who is responsible for keeping .buildkite/version_bump_pipeline.yml up to date? Wonder if adding a CODEOWNERS could help here,
💚 Build Succeeded
History
|
|
Hey Victor, could you please merge this PR as well, thank you! For |
I'm waiting for the rest of the Logstash team to review it. |
| key: block-get-dra-artifacts | ||
| blocked_state: running | ||
|
|
||
| - label: "Fetch DRA Artifacts" |
There was a problem hiding this comment.
I'm having trouble understanding what this is for? Why do we want to poll for artifacts? What consumes this?
There was a problem hiding this comment.
Hello, let me try to answer your questions the best I can.
Why do we want to poll for artifacts?
We (Release-eng) poll for artifacts as the last step to ensure that the version for the artifacts have been bumped.
What consumes this?
We'll be using a centralized pipeline (owned by release-eng) which will be used alongside the pipeline in this PR. How it'll work is that the centralized pipeline will trigger the service team's version bump pipeline using a dependency graph.
| steps: | ||
| # TODO: replace this block step by real version bump logic | ||
| - block: "Ready to fetch for DRA artifacts?" | ||
| prompt: | |
There was a problem hiding this comment.
Why is "prompt" used here? Will this just consistently be in a "waiting" state? How is that different than just running the pipeline when needed?
There was a problem hiding this comment.
The entire block step is to be replaced by each team. This block step is more of a placeholder.
|
I would like to understand more the exact use case here for logstash... Today, the process for version bumps (IE the day a release goes out):
Is the intent of this new proposed pipeline to orchestrate all three of those steps? Or is there something else I'm missing? |
No, the new proposed pipeline will be used by the centralized pipeline. The version bump logic itself will still be handled by each service team. There's more details in the PSI regarding the pipeline in section 3. Hope this helps! |
Release notes
[rn:skip]
What does this PR do?
Hi Team,
This PR is the first phase of the version-bump automation rollout as mentioned in #mission-control. It introduces a generalized Buildkite pipeline for service teams in the DRA process. The baseline pipeline includes a block step that waits for each team to unblock before polling for DRA artifacts using a buildkite plugin json-watcher-buildkite-plugin for the polling.
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
If you haven't already, please provide the Slack channel name for notifications via a comment here or on the issue listed aboveUse cases
Screenshots
Logs