Skip to content

[ML] Enhance error logging in CJsonStateRestoreTraverser for improved debugging. #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

[ML] Enhance error logging in CJsonStateRestoreTraverser for improved debugging. #2867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243474a
[ML] Enhance error logging in CJsonStateRestoreTraverser for improved…
valeriy42 Oct 9, 2025
9c14299
formatting
valeriy42 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 66 additions & 2 deletions lib/core/CJsonStateRestoreTraverser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,62 @@ bool CJsonStateRestoreTraverser::start() {
return false;
}

LOG_ERROR(<< "JSON state must be object at root" << m_Handler.s_Type);
// Enhanced error logging with comprehensive debugging information
std::string tokenTypeName;
switch (m_Handler.s_Type) {
case SBoostJsonHandler::E_TokenNull:
tokenTypeName = "null";
break;
case SBoostJsonHandler::E_TokenKey:
tokenTypeName = "key";
break;
case SBoostJsonHandler::E_TokenBool:
tokenTypeName = "boolean";
break;
case SBoostJsonHandler::E_TokenInt64:
tokenTypeName = "int64";
break;
case SBoostJsonHandler::E_TokenUInt64:
tokenTypeName = "uint64";
break;
case SBoostJsonHandler::E_TokenDouble:
tokenTypeName = "double";
break;
case SBoostJsonHandler::E_TokenString:
tokenTypeName = "string";
break;
case SBoostJsonHandler::E_TokenObjectStart:
tokenTypeName = "object_start";
break;
case SBoostJsonHandler::E_TokenObjectEnd:
tokenTypeName = "object_end";
break;
case SBoostJsonHandler::E_TokenArrayStart:
tokenTypeName = "array_start";
break;
case SBoostJsonHandler::E_TokenArrayEnd:
tokenTypeName = "array_end";
break;
case SBoostJsonHandler::E_TokenKeyPart:
tokenTypeName = "key_part";
break;
case SBoostJsonHandler::E_TokenStringPart:
tokenTypeName = "string_part";
break;
default:
tokenTypeName = "unknown";
break;
}

LOG_ERROR(<< "JSON state must be object at root. Found token type: "
<< tokenTypeName << " (value: " << m_Handler.s_Type
<< "), isArrayOfObjects: " << m_IsArrayOfObjects
<< ", isEof: " << this->isEof()
<< ", stream state - bad: " << m_ReadStream.bad()
<< ", fail: " << m_ReadStream.fail()
<< ", eof: " << m_ReadStream.eof()
<< ", bytes remaining: " << m_BytesRemaining
<< ", buffer position: " << (m_BufferPtr ? (m_BufferPtr - m_Buffer) : -1));
return false;
}

Expand Down Expand Up @@ -349,7 +404,16 @@ bool CJsonStateRestoreTraverser::advance() {
}

void CJsonStateRestoreTraverser::logError() {
LOG_ERROR(<< "Error parsing JSON: " << m_Reader.last_error());
LOG_ERROR(<< "Error parsing JSON: " << m_Reader.last_error()
<< ", stream state - bad: " << m_ReadStream.bad()
<< ", fail: " << m_ReadStream.fail()
<< ", eof: " << m_ReadStream.eof()
<< ", bytes remaining: " << m_BytesRemaining
<< ", buffer position: " << (m_BufferPtr ? (m_BufferPtr - m_Buffer) : -1)
<< ", current token type: " << m_Handler.s_Type
<< ", isArrayOfObjects: " << m_IsArrayOfObjects
<< ", started: " << m_Started
<< ", desired level: " << m_DesiredLevel);
this->setBadState();
}

Expand Down